Dead code in ceval_macros.h and ceval_gil.c

The _Py_atomic_load_relaxed_int32 macro is no longer used:

Lines 378 to 383 in d323997

    
           // GH-89279: Force inlining by using a macro. 
        
           #if defined(_MSC_VER) && SIZEOF_INT == 4 
        
           #define _Py_atomic_load_relaxed_int32(ATOMIC_VAL) (assert(sizeof((ATOMIC_VAL)->_value) == 4), *((volatile int*)&((ATOMIC_VAL)->_value))) 
        
           #else 
        
           #define _Py_atomic_load_relaxed_int32(ATOMIC_VAL) _Py_atomic_load_relaxed(ATOMIC_VAL) 
        
           #endif

cpython/Python/ceval_gil.c

Lines 52 to 57 in d323997

    
           // GH-89279: Force inlining by using a macro. 
        
           #if defined(_MSC_VER) && SIZEOF_INT == 4 
        
           #define _Py_atomic_load_relaxed_int32(ATOMIC_VAL) (assert(sizeof((ATOMIC_VAL)->_value) == 4), *((volatile int*)&((ATOMIC_VAL)->_value))) 
        
           #else 
        
           #define _Py_atomic_load_relaxed_int32(ATOMIC_VAL) _Py_atomic_load_relaxed(ATOMIC_VAL) 
        
           #endif

Linked PRs

gh-122860: Remove unused macro _Py_atomic_load_relaxed_int32 #122861

pythongh-122860: Remove unused macro `_Py_atomic_load_relaxed_int32`

They were added by #32387. I can confirm that the new _Py_atomic_* functions are all inlined by MSVC (Release, PGO).

gh-122860: Remove unused macro `_Py_atomic_load_relaxed_int32` (#122861)

pythongh-122860: Remove unused macro `_Py_atomic_load_relaxed_int32` (p…

Navigation Menu

Repository navigation

Dead code in ceval_macros.h and ceval_gil.c #122860

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	// GH-89279: Force inlining by using a macro.
	#if defined(_MSC_VER) && SIZEOF_INT == 4
	#define _Py_atomic_load_relaxed_int32(ATOMIC_VAL) (assert(sizeof((ATOMIC_VAL)->_value) == 4), ((volatile int)&((ATOMIC_VAL)->_value)))
	#else
	#define _Py_atomic_load_relaxed_int32(ATOMIC_VAL) _Py_atomic_load_relaxed(ATOMIC_VAL)
	#endif

Dead code in ceval_macros.h and ceval_gil.c #122860

Description

Linked PRs

Activity

neonene commented on Aug 10, 2024

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions