Skip to content

Fix support of var-positional parameter in Argument Clinic #122688

Closed
Closed
Fix support of var-positional parameter in Argument Clinic#122688
Labels
3.12only security fixes3.13only security fixes3.14bugs and security fixestopic-argument-clinic

Description

@serhiy-storchaka
serhiy-storchaka
opened on Aug 5, 2024

Currently Argument Clinic with a var-positional parameter is only used in few functions (print(), the TypeVar constructor (see #118814) and several set methods), so this is not well tested.

There are several bugs here:

  • Keyword-only parameters after the var-positional parameter are marked as positional-or-keyword parameters.
  • The number of required arguments for keyword-only parameters was calculated incorrectly.
  • Some invalid combination of the var-positional parameter with /, * and deprecation markers are not forbidden or produce unrelated errors.

Linked PRs

Activity

  1. serhiy-storchaka
    added
    topic-argument-clinic
    3.12only security fixes
    3.13only security fixes
    3.14bugs and security fixes
    on Aug 5, 2024
  2. serhiy-storchaka
    added 3 commits that reference this issue on Aug 5, 2024

    pythongh-122688: Fix support of var-positional parameter in Argument …

    61e719b

    gh-122688: Fix support of var-positional parameter in Argument Clinic (…

    8393608

    [3.13] pythongh-122688: Fix support of var-positional parameter in Ar…

    a9a654a

  3. serhiy-storchaka commented on Aug 9, 2024

    @serhiy-storchaka
    serhiy-storchaka
    on Aug 9, 2024
    MemberAuthor

    Due to refactoring it is difficult to backport this change to 3.12. This is not such important, because these corner cases are not used in CPython for now.

    But I am planning to merge it in 3.13 after release, to help backporting future bugfixes. I am currently working on significant rewriting of the code for this feature, and found few other errors.

  4. serhiy-storchaka
    added 2 commits that reference this issue on Aug 11, 2024

    pythongh-122688: Add more tests for var-positional parameters in Argu…

    8efce2a

    gh-122688: Add more tests for var-positional parameters in Argument C…

    f9ba1f3
  5. blhsing
    added 2 commits that reference this issue on Aug 22, 2024

    pythongh-122688: Fix support of var-positional parameter in Argument …

    a317ccd

    pythongh-122688: Add more tests for var-positional parameters in Argu…

    b96bb35
  6. Yhg1s
    added a commit that references this issue on Sep 2, 2024

    [3.13] gh-122688: Fix support of var-positional parameter in Argument…

    8b6dd92
  7. serhiy-storchaka
    closed this as completedon Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.12only security fixes3.13only security fixes3.14bugs and security fixestopic-argument-clinic

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions