Repository navigation
3.13 copy.replace isn't in __all__ #121300
Description
Bug report
Bug description:
copy.replace isn't exported as a part of __all__ in the copy module. This seemed liked an oversight, as opposed to being intentional, but feel free to close this issue if not.
CPython versions tested on:
3.13
Operating systems tested on:
No response
Activity
max-muoto commentedon Jul 3, 2024
CC: @serhiy-storchaka
pygeek commentedon Jul 3, 2024
Nice catch:
#108752
Eclips4 commentedon Jul 3, 2024
Hello!
Nice catch. This definitely should be in
__all__since this is part of the public API.Would you like to send a PR with fix?
max-muoto commentedon Jul 3, 2024
Will do! Thanks for catching @JelleZijlstra!
pythongh-121300: Update `__all__` to include `copy.replace`
max-muoto commentedon Jul 3, 2024
@Eclips4 #121302
serhiy-storchaka commentedon Jul 3, 2024
Sure, this is an oversight.
pydoc copyshould showreplace.max-muoto commentedon Jul 3, 2024
Do you want a separate PR here (adding it to the module docstring)? Or can add it into the existing one I have.
pygeek commentedon Jul 3, 2024
I know this is a trivial change, but we should probably add a regression test for
__all__. Seesupport.test__all__helper method in the test directory.serhiy-storchaka commentedon Jul 3, 2024
Adding it to the module docstring is also a good idea. You can include this in your PR or create a separate PR if you wish.
max-muoto commentedon Jul 3, 2024
Let me just do that in the current PR, I'm also going to add a test case.
gh-121300: Add `replace` to `copy.__all__` (#121302)
pythongh-121300: Add `replace` to `copy.__all__` (pythonGH-121302)
[3.13] gh-121300: Add `replace` to `copy.__all__` (GH-121302) (#121337)
Eclips4 commentedon Jul 4, 2024
Thanks!
pythongh-121300: Add `replace` to `copy.__all__` (python#121302)
pythongh-121300: Add `replace` to `copy.__all__` (python#121302)