Skip to content

importlib.abc: NameError: name 'warnings' is not defined #121279

Closed
Closed
importlib.abc: NameError: name 'warnings' is not defined#121279
Labels
type-bugAn unexpected behavior, bug, or error

Description

@hroncok
hroncok
opened on Jul 2, 2024

Bug report

Bug description:

>>> import importlib.abc
>>> importlib.abc.TraversableResources
Traceback (most recent call last):
  File "<python-input-3>", line 1, in <module>
    importlib.abc.TraversableResources
  File "/usr/lib64/python3.13/importlib/abc.py", line 34, in __getattr__
    warnings._deprecated(f"{__name__}.{name}", remove=(3, 14))
    ^^^^^^^^
NameError: name 'warnings' is not defined. Did you mean: 'Warning'? Or did you forget to import 'warnings'?

This is a result of #120429

Thew change on the main branch correctly removed unused import warnings, but ti got backported to 3.13 where the import is used.

CPython versions tested on:

3.13

Operating systems tested on:

Linux

Linked PRs

Activity

  1. hroncok
    added
    type-bugAn unexpected behavior, bug, or error
    on Jul 2, 2024

  2. hroncok commented on Jul 2, 2024

    @hroncok
    hroncok
    on Jul 2, 2024
    ContributorAuthor

    Working on a PR.

  3. hroncok
    added 2 commits that reference this issue on Jul 2, 2024

    [3.13] pythongh-121279: Re-add prematurely removed import warnings to…

    85f8d45

    [3.13] pythongh-121279: Re-add prematurely removed import warnings to…

    4f3e53f
  4. vstinner
    added a commit that references this issue on Jul 3, 2024

    [3.13] gh-121279: Re-add prematurely removed import warnings to impor…

    dacf4ff

  5. vstinner commented on Jul 3, 2024

    @vstinner
    vstinner
    on Jul 3, 2024
    Member

    Fixed by dacf4ff.

  6. vstinner
    closed this as completedon Jul 3, 2024

  7. encukou commented on Jul 3, 2024

    @encukou
    encukou
    on Jul 3, 2024
    Member

    The fix fails in refleaks buildbots:

    Reproducible with:

    ./python -m test test_importlib -m 'test_deprecated*' -R:
  8. encukou
    reopened this on Jul 3, 2024

  9. hroncok commented on Jul 3, 2024

    @hroncok
    hroncok
    on Jul 3, 2024
    ContributorAuthor

    The failure is AssertionError: DeprecationWarning not triggered

    I assume that when the test runs multiple times, the DeprecationWarning is no longer triggered. I would need to see how other tests do this.

  10. vstinner
    added a commit that references this issue on Jul 3, 2024

    [3.13] pythongh-121279: Fix importlib DeprecatedAttrsTests

    373df46

  11. vstinner commented on Jul 3, 2024

    @vstinner
    vstinner
    on Jul 3, 2024
    Member

    The fix fails in refleaks buildbots:

    I propose a fix for that: #121319

  12. hroncok commented on Jul 3, 2024

    @hroncok
    hroncok
    on Jul 3, 2024
    ContributorAuthor

    Apologies for breaking the buildbots. TIL I need to run my tests with -R: to check this.

  13. vstinner commented on Jul 3, 2024

    @vstinner
    vstinner
    on Jul 3, 2024
    Member

    It's uncommon that tests only fail with -R, don't worry.

  14. vstinner
    added a commit that references this issue on Jul 3, 2024

    [3.13] gh-121279: Fix importlib DeprecatedAttrsTests (#121319)

    ec0f801

  15. vstinner commented on Jul 3, 2024

    @vstinner
    vstinner
    on Jul 3, 2024
    Member

    The fix fails in refleaks buildbots:

    It should be fixed by: ec0f801

  16. vstinner
    closed this as completedon Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions