Improve deprecation warning message, when a test case returns non None value

Feature or enhancement

Right now there are two potential things we can improve in this warning message:

Lines 605 to 609 in 19435d2

    
           def _callTestMethod(self, method): 
        
               if method() is not None: 
        
                   warnings.warn(f'It is deprecated to return a value that is not None from a ' 
        
                                 f'test case ({method})', DeprecationWarning, stacklevel=3)

The returned value's type is not shown. It can be useful for users
A common case for this warning is that async def test_some is defined in a regular TestCase class, I think that we can improve this specific case and suggest to use IsolatedAsyncioTestCase instead

I have a patch ready.

Linked PRs

gh-120388: Improve deprecation warning message, when test returns non-None #120401

pythongh-120388: Improve deprecation warning message, when test retur…

gh-120388: Improve deprecation warning message, when test returns non…

@sobolevn

Thanks for doing this @sobolevn! :D

pythongh-120388: Improve deprecation warning message, when test retur…

Navigation Menu

Repository navigation

Improve deprecation warning message, when a test case returns non `None` value #120388

Feature or enhancement

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	def _callTestMethod(self, method):
	if method() is not None:
	warnings.warn(f'It is deprecated to return a value that is not None from a '
	f'test case ({method})', DeprecationWarning, stacklevel=3)

Improve deprecation warning message, when a test case returns non None value #120388

Description

Feature or enhancement

Linked PRs

Activity

AlexWaygood commented on Jun 12, 2024

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

Improve deprecation warning message, when a test case returns non `None` value #120388