Overriding SIGINT doesn't work as expected in the new REPL

Bug report

In the old REPL, overriding SIGINT and pressing Ctrl-C works as expected:

❯ python
Python 3.11.6 (main, Nov  3 2023, 17:05:41) [Clang 15.0.0 (clang-1500.0.40.1)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import signal
>>> signal.signal(signal.SIGINT, lambda *x: print("NOOOO"))
<built-in function default_int_handler>
>>> NOOOO
NOOOO

but in the new REPL it doesn't trigger the signal handler:

❯ ./python.exe
Python 3.14.0a0 (heads/more_offsets-dirty:9403c2cf58, Jun  6 2024, 12:10:11) [Clang 15.0.0 (clang-1500.3.9.4)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import signal
>>> signal.signal(signal.SIGINT, lambda *x: print("NOOOO"))
<built-in function default_int_handler>
>>>
KeyboardInterrupt
>>>

Linked PRs

@lysnikolaou

CC: @lysnikolaou @ambv

This will be fixed by #120234

I noticed the problem when trying to debug Python in gdb. CTRL+C doesn't go into gdb anymore. For now, I'm using a bash alias:

alias gdb='PYTHON_BASIC_REPL=1 gdb'

pythongh-120221: Deliver real singals on Ctrl-C and Ctrl-Z in the new…

gh-120221: Deliver real singals on Ctrl-C and Ctrl-Z in the new REPL (#…

pythongh-120221: Deliver real singals on Ctrl-C and Ctrl-Z in the new…

[3.13] gh-120221: Deliver real singals on Ctrl-C and Ctrl-Z in the ne…

Thank you. CTRL+C is gdb stops again the process as expected :)

This could have been addressed by changing default_keymap in "Lib/_pyepl/reader.py" to map (r"\x03", "interrupt") instead of mapping it to the ctrl_c command. The interrupt command calls os.kill(os.getpid(), signal.SIGINT), which works fine for overriding the SIGINT handler and supporting gdb. That said, the decision to let the terminal send the signal makes it equivalent to how it's currently implemented on Windows, and consistency is a plus.

This could have been addressed by changing default_keymap in "Lib/_pyepl/reader.py" to map (r"\x03", "interrupt") instead of mapping it to the ctrl_c command. The interrupt command calls os.kill(os.getpid(), signal.SIGINT), which works fine for overriding the SIGINT handler and supporting gdb. That said, the decision to let the terminal send the signal makes it equivalent to how it's currently implemented on Windows, and consistency is a plus.

The problem of that approach is that if you paste a huge buffer and then want to cancel because pasting it's too slow then you need to wait until you get the key press for Ctrl-C to send the signal, which will happen after all the buffer is processed, while using signals directly allows us to cancel almost immediately

pythongh-120221: Deliver real singals on Ctrl-C and Ctrl-Z in the new…

This broke CTRL-C in the asyncio REPL. Now the interrupt and ctrl_c commands are never executed. I need some more time to investigate what happens on Windows to not break that when fixing Linux/Mac.

pythongh-120221: Support KeyboardInterrupt in asyncio REPL

gh-120221: Support KeyboardInterrupt in asyncio REPL (#123795)

pythongh-120221: Support KeyboardInterrupt in asyncio REPL (pythonGH-…

[3.13] gh-120221: Support KeyboardInterrupt in asyncio REPL (GH-123795)…

Fixed by #123799.

Navigation Menu

Repository navigation

Overriding SIGINT doesn't work as expected in the new REPL #120221

Bug report

Linked PRs

1 remaining item

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Overriding SIGINT doesn't work as expected in the new REPL #120221

Description

Bug report

Linked PRs

Activity

pablogsal commented on Jun 7, 2024

pablogsal commented on Jun 7, 2024

vstinner commented on Jun 11, 2024

1 remaining item

vstinner commented on Jun 12, 2024

eryksun commented on Jun 19, 2024

pablogsal commented on Jun 19, 2024

ambv commented on Sep 6, 2024

ambv commented on Sep 6, 2024

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions