Skip to content

New REPL exposes its internal imports/definitions to top-level environment #118908

Open
Open
New REPL exposes its internal imports/definitions to top-level environment#118908
Labels
3.13only security fixes3.14bugs and security fixestopic-replRelated to the interactive shelltype-bugAn unexpected behavior, bug, or error

Description

@chgnrdv
chgnrdv
opened on May 10, 2024

Bug report

Bug description:

Top-level scope now contains globals of _pyrepl.__main__:

Python 3.14.0a0 (heads/main:a895756aec, May 10 2024, 16:56:55) [GCC 10.2.1 20210110] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> dir()
['CAN_USE_PYREPL', '__annotations__', '__builtins__', '__cached__', '__doc__', '__file__',
'__loader__', '__name__', '__package__', '__spec__', 'interactive_console', 'os', 'sys']

CPython versions tested on:

3.13

Operating systems tested on:

Linux

Linked PRs

Activity

  1. chgnrdv
    added
    type-bugAn unexpected behavior, bug, or error
    on May 10, 2024
  2. hugovk
    added
    topic-replRelated to the interactive shell
    3.13only security fixes
    3.14bugs and security fixes
    on May 10, 2024
  3. pablogsal
    added a commit that references this issue on Jun 11, 2024

    gh-118908: Limit exposed globals from internal imports and definition…

    86a8a1c
  4. miss-islington
    added a commit that references this issue on Jun 11, 2024

    pythongh-118908: Limit exposed globals from internal imports and defi…

    7039225
  5. pablogsal
    added a commit that references this issue on Jun 11, 2024

    [3.13] gh-118908: Limit exposed globals from internal imports and def…

    f5289c4
  6. lysnikolaou
    closed this as completedon Jun 11, 2024
  7. lysnikolaou
    added a commit that references this issue on Jun 11, 2024

    pythongh-118908: Fix completions after namespace change in REPL

    be15c89

  8. encukou commented on Jun 12, 2024

    @encukou
    encukou
    on Jun 12, 2024
    Member

    It seems that this change broke a buildbot, see: https://buildbot.python.org/all/#/builders/249/builds/8895/steps/5/logs/stdio

  9. encukou
    reopened this on Jun 12, 2024
  10. lysnikolaou
    added a commit that references this issue on Jun 12, 2024

    gh-118908: Fix completions after namespace change in REPL (#120370)

    02e74c3
  11. miss-islington
    added a commit that references this issue on Jun 12, 2024

    pythongh-118908: Fix completions after namespace change in REPL (pyth…

    f7e572c
  12. lysnikolaou
    added a commit that references this issue on Jun 12, 2024

    [3.13] gh-118908: Fix completions after namespace change in REPL (GH-…

    10821cc

  13. pablogsal commented on Jun 12, 2024

    @pablogsal
    pablogsal
    on Jun 12, 2024
    Member

    It seems that this change broke a buildbot, see: https://buildbot.python.org/all/#/builders/249/builds/8895/steps/5/logs/stdio

    It looks like a timeout.... I will try to investigate today

  14. 10 remaining items

  15. ambv
    added a commit that references this issue on Jun 26, 2024

    gh-118908: Use __main__ for the default PyREPL namespace (#121054)

    d611c4c
  16. miss-islington
    added a commit that references this issue on Jun 26, 2024

    pythongh-118908: Use __main__ for the default PyREPL namespace (pytho…

    34c417c
  17. ambv
    added a commit that references this issue on Jun 26, 2024

    [3.13] gh-118908: Use __main__ for the default PyREPL namespace (GH-1…

    38cfa92
  18. mrahtz
    added 4 commits that reference this issue on Jun 30, 2024

    pythongh-118908: Limit exposed globals from internal imports and defi…

    f78e612

    pythongh-118908: Fix completions after namespace change in REPL (pyth…

    f721d1d

    pythongh-118908: Protect the REPL subprocess with a timeout in tests (p…

    a7dc70b

    pythongh-118908: Use __main__ for the default PyREPL namespace (pytho…

    0256ec0
  19. noahbkim
    added 4 commits that reference this issue on Jul 11, 2024

    pythongh-118908: Limit exposed globals from internal imports and defi…

    4b1368b

    pythongh-118908: Fix completions after namespace change in REPL (pyth…

    a115c21

    pythongh-118908: Protect the REPL subprocess with a timeout in tests (p…

    f9809fa

    pythongh-118908: Use __main__ for the default PyREPL namespace (pytho…

    4413ef8
  20. estyxx
    added 4 commits that reference this issue on Jul 17, 2024

    pythongh-118908: Limit exposed globals from internal imports and defi…

    1f09cb7

    pythongh-118908: Fix completions after namespace change in REPL (pyth…

    4b5ad7e

    pythongh-118908: Protect the REPL subprocess with a timeout in tests (p…

    06e9e62

    pythongh-118908: Use __main__ for the default PyREPL namespace (pytho…

    dcb1755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.13only security fixes3.14bugs and security fixestopic-replRelated to the interactive shelltype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions