Repository navigation
Configure Tier 2 interpreter at build time #118335
Description
Activity
@mdboom this will have some consequences for the benchmarking infra; checking the Tier 2 box should use this configure option rather than setting the PYTHON_UOPS=1 env var. It should be possible to use both (./configure gives a warning but otherwise seems to ignore incorrect flags, and the env var will just be ignored).
That should be easy enough to deal with, but I'll hold off on shipping that change until #118339 is merged.
That should be easy enough to deal with, but I'll hold off on shipping that change until #118339 is merged.
Understood, but then how can I run a benchmark that tells me how Tier 2 fares with my changes before merging it? (Possibly we won't care. We should discuss this in today's meeting.)
Oh, good point. If I'm reading correctly, we could probably do both the
./configureflag and the environment variable for a while (and then remove the environment variable).Off-line we decided on a different configure experience. The
--configure-experimental-jitflag will be extended so you can write./configure --enable-experimental-jit={off|yes|no|interp}(enum names subject to bikeshedding) which selects whether the JIT or the Tier 2 interpreter is built, and whether it's on or off by default. An environment variable,
PYTHON_JIT={0|1}can override whatever is built.Meanwhile, Brandt and I solved the Windows failure, which was due to
_Py_JITbeing undefined when_testinternalcapi.cwas being compiled in JIT mode. Fix forthcoming.
It would be nice if by default we didn't ship the optimizer infrastructure, since approximately nobody is going to use it, so we should ship (and by default build) binaries that just don't include it.
I propose to enable it only when configured with
--enable-experimental-jit-interpreter. We drop support forPYTHON_UOPSand-Xuops, in favor ofPYTHON_JIT=0|1.@mdboom this will have some consequences for the benchmarking infra; checking the
Tier 2box should use this configure option rather than setting thePYTHON_UOPS=1env var. It should be possible to use both (./configuregives a warning but otherwise seems to ignore incorrect flags, and the env var will just be ignored).Linked PRs