Skip to content

Regression in tricky __dict__ use. #117838

Closed
Closed
Regression in tricky __dict__ use.#117838
Labels
3.13only security fixesinterpreter-core(Objects, Python, Grammar, and Parser dirs)release-blockertype-bugAn unexpected behavior, bug, or error

Description

@felixxm
felixxm
opened on Apr 13, 2024

Bug report

Bug description:

I noticed a regression in Python 3.13.0 alpha 6. Django LazySettings started to crash because _wrapper is no longer set to the empty sentinel. I bisected this regression to the c32dc47, so it's related with the recent changes in __dict__.

Django's LazySettings and LazyObject are quite tricky. I will try to provide a small reproducer later.

CPython versions tested on:

3.13

Operating systems tested on:

Linux

Activity

  1. felixxm
    added
    type-bugAn unexpected behavior, bug, or error
    on Apr 13, 2024

  2. ronaldoussoren commented on Apr 13, 2024

    @ronaldoussoren
    ronaldoussoren
    on Apr 13, 2024
    Contributor

    Issue #117750 is likely related to this.

  3. hugovk
    added
    3.13only security fixes
    interpreter-core(Objects, Python, Grammar, and Parser dirs)
    release-blocker
    on Apr 13, 2024
  4. ezio-melotti
    added this to Release and Deferred blockers 🚫on Apr 13, 2024
  5. github-project-automation
    moved this to Todo in Release and Deferred blockers 🚫on Apr 13, 2024

  6. encukou commented on Apr 16, 2024

    @encukou
    encukou
    on Apr 16, 2024
    Member

    The dict issue is fixed on main (#117808), but the Django tests now fail with another assertion added as part of the same change:

    python: ./Include/internal/pycore_object.h:283: _PyObject_Init: Assertion `_PyType_HasFeature(typeobj, Py_TPFLAGS_HEAPTYPE) || _Py_IsImmortal(typeobj)' failed.

    cc @markshannon

  7. markshannon commented on Apr 16, 2024

    @markshannon
    markshannon
    on Apr 16, 2024
    Member

    Should be fixed by #117673.

  8. felixxm commented on Apr 16, 2024

    @felixxm
    felixxm
    on Apr 16, 2024
    ContributorAuthor

    Let me confirm 🕵️‍♂️

  9. felixxm commented on Apr 16, 2024

    @felixxm
    felixxm
    on Apr 16, 2024
    ContributorAuthor

    It works for me 🎉 Many thanks for help 🧑‍🚒

  10. felixxm
    closed this as completedon Apr 16, 2024
  11. github-project-automation
    moved this from Todo to Done in Release and Deferred blockers 🚫on Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.13only security fixesinterpreter-core(Objects, Python, Grammar, and Parser dirs)release-blockertype-bugAn unexpected behavior, bug, or error

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions