Repository navigation
FAIL: test_makefile_test_folders (test.test_tools.test_makefile.TestMakefile.test_makefile_test_folders) #117166
Description
Bug description:
Configuration:
./configure --with-pydebugTest:
./python -m test test_tools --junit-xml test-resuls.xml -j2 --timeout 1200 -vOutput:
FAIL: test_makefile_test_folders (test.test_tools.test_makefile.TestMakefile.test_makefile_test_folders) (relpath='test/test_lib2to3')
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/arf/cpython/Lib/test/test_tools/test_makefile.py", line 51, in test_makefile_test_folders
self.assertIn(
~~~~~~~~~~~~~^
relpath,
^^^^^^^^
...<4 lines>...
)
^
)
^
AssertionError: 'test/test_lib2to3' not found in ['idlelib/idle_test', 'test', 'test/archivetestdata', 'test/audiodata', 'test/certdata', 'test/certdata/capath', 'test/cjkencodings', 'test/configdata', 'test/crashers', 'test/data', 'test/decimaltestdata', 'test/dtracedata', 'test/encoded_modules', 'test/leakers', 'test/libregrtest', 'test/mathdata', 'test/regrtestdata', 'test/regrtestdata/import_from_tests', 'test/regrtestdata/import_from_tests/test_regrtest_b', 'test/subprocessdata', 'test/support', 'test/support/_hypothesis_stubs', 'test/support/interpreters', 'test/test_asyncio', 'test/test_capi', 'test/test_cext', 'test/test_concurrent_futures', 'test/test_cppext', 'test/test_ctypes', 'test/test_dataclasses', 'test/test_doctest', 'test/test_email', 'test/test_email/data', 'test/test_future_stmt', 'test/test_gdb', 'test/test_import', 'test/test_import/data', 'test/test_import/data/circular_imports', 'test/test_import/data/circular_imports/subpkg', 'test/test_import/data/circular_imports/subpkg2', 'test/test_import/data/circular_imports/subpkg2/parent', 'test/test_import/data/package', 'test/test_import/data/package2', 'test/test_import/data/unwritable', 'test/test_importlib', 'test/test_importlib/builtin', 'test/test_importlib/extension', 'test/test_importlib/frozen', 'test/test_importlib/import_', 'test/test_importlib/metadata', 'test/test_importlib/metadata/data', 'test/test_importlib/metadata/data/sources', 'test/test_importlib/metadata/data/sources/example', 'test/test_importlib/metadata/data/sources/example/example', 'test/test_importlib/metadata/data/sources/example2', 'test/test_importlib/metadata/data/sources/example2/example2', 'test/test_importlib/namespace_pkgs', 'test/test_importlib/namespace_pkgs/both_portions', 'test/test_importlib/namespace_pkgs/both_portions/foo', 'test/test_importlib/namespace_pkgs/module_and_namespace_package', 'test/test_importlib/namespace_pkgs/module_and_namespace_package/a_test', 'test/test_importlib/namespace_pkgs/not_a_namespace_pkg', 'test/test_importlib/namespace_pkgs/not_a_namespace_pkg/foo', 'test/test_importlib/namespace_pkgs/portion1', 'test/test_importlib/namespace_pkgs/portion1/foo', 'test/test_importlib/namespace_pkgs/portion2', 'test/test_importlib/namespace_pkgs/portion2/foo', 'test/test_importlib/namespace_pkgs/project1', 'test/test_importlib/namespace_pkgs/project1/parent', 'test/test_importlib/namespace_pkgs/project1/parent/child', 'test/test_importlib/namespace_pkgs/project2', 'test/test_importlib/namespace_pkgs/project2/parent', 'test/test_importlib/namespace_pkgs/project2/parent/child', 'test/test_importlib/namespace_pkgs/project3', 'test/test_importlib/namespace_pkgs/project3/parent', 'test/test_importlib/namespace_pkgs/project3/parent/child', 'test/test_importlib/partial', 'test/test_importlib/resources', 'test/test_importlib/resources/data01', 'test/test_importlib/resources/data01/subdirectory', 'test/test_importlib/resources/data02', 'test/test_importlib/resources/data02/one', 'test/test_importlib/resources/data02/subdirectory', 'test/test_importlib/resources/data02/subdirectory/subsubdir', 'test/test_importlib/resources/data02/two', 'test/test_importlib/resources/data03', 'test/test_importlib/resources/data03/namespace', 'test/test_importlib/resources/data03/namespace/portion1', 'test/test_importlib/resources/data03/namespace/portion2', 'test/test_importlib/resources/namespacedata01', 'test/test_importlib/resources/zipdata01', 'test/test_importlib/resources/zipdata02', 'test/test_importlib/source', 'test/test_inspect', 'test/test_interpreters', 'test/test_json', 'test/test_module', 'test/test_multiprocessing_fork', 'test/test_multiprocessing_forkserver', 'test/test_multiprocessing_spawn', 'test/test_pathlib', 'test/test_peg_generator', 'test/test_pydoc', 'test/test_sqlite3', 'test/test_tkinter', 'test/test_tomllib', 'test/test_tomllib/data', 'test/test_tomllib/data/invalid', 'test/test_tomllib/data/invalid/array', 'test/test_tomllib/data/invalid/array-of-tables', 'test/test_tomllib/data/invalid/boolean', 'test/test_tomllib/data/invalid/dates-and-times', 'test/test_tomllib/data/invalid/dotted-keys', 'test/test_tomllib/data/invalid/inline-table', 'test/test_tomllib/data/invalid/keys-and-vals', 'test/test_tomllib/data/invalid/literal-str', 'test/test_tomllib/data/invalid/multiline-basic-str', 'test/test_tomllib/data/invalid/multiline-literal-str', 'test/test_tomllib/data/invalid/table', 'test/test_tomllib/data/valid', 'test/test_tomllib/data/valid/array', 'test/test_tomllib/data/valid/dates-and-times', 'test/test_tomllib/data/valid/multiline-basic-str', 'test/test_tools', 'test/test_ttk', 'test/test_unittest', 'test/test_unittest/testmock', 'test/test_warnings', 'test/test_warnings/data', 'test/test_zipfile', 'test/test_zipfile/_path', 'test/test_zoneinfo', 'test/test_zoneinfo/data', 'test/tkinterdata', 'test/tokenizedata', 'test/tracedmodules', 'test/typinganndata', 'test/wheeldata', 'test/xmltestdata', 'test/xmltestdata/c14n-20'] : 'test/test_lib2to3' is not included in the Makefile's list of test directories to installCPython versions tested on:
CPython main branch
Operating systems tested on:
Linux
Activity
serhiy-storchaka commentedon Mar 22, 2024
I get another failure:
cc @sobolevn
sobolevn commentedon Mar 22, 2024
Thanks, fixing!
sobolevn commentedon Mar 23, 2024
I can reprode @serhiy-storchaka's failure (by installing
ruffin that folder).But, how did you get
test_lib2to3inmain, @furkanonder ? 🤔sobolevn commentedon Mar 23, 2024
Basically, my fix is: ignore empty folders and ignore folders that start with
.serhiy-storchaka commentedon Mar 23, 2024
I guess that @furkanonder has some dot-files or temporary or backup files (ending with
~or like) intest_lib2to3or its subdirectories. When the content oftest_lib2to3was deleted inmain, the directory was kept because it contains some files not managed by Git.pythongh-117166: Ignore empty and temporary dirs in `test_makefile`
furkanonder commentedon Mar 25, 2024
Actually, I am not sure how the error happened. This issue occurred in the scenario where running buildbot. Perhaps that occurred while the buildbot was changing the branch. (I'm not sure if the branch is changing; I'm quite new to buildbots).
The directory structure of buildbot looks like this:
serhiy-storchaka commentedon Mar 25, 2024
What is the content of the
test/test_lib2to3directory and its subdirectories?furkanonder commentedon Mar 25, 2024
I ran the test again, there was no problem with
'test/test_lib2to3. There are issues with different directories.sobolevn commentedon Mar 25, 2024
@furkanonder how can I reproduce this locally? 🤔
furkanonder commentedon Mar 25, 2024
From FreeBSD 13.2-RELEASE-p10 aarch64;
furkanonder commentedon Mar 25, 2024
Unfortunately I don't know the exact way, all I did was clone the repository, compile and test it.
sobolevn commentedon Mar 25, 2024
But, these directories does not exit:
while multiple others are clearly listed, like
test/test_cext🤔
furkanonder commentedon Mar 25, 2024
@sobolevn It is here.
sobolevn commentedon Mar 26, 2024
@furkanonder can you please share more info?
mainversion does not have these directories. It is a fact.So, for some reason this buildbot show directories that are not present. This might happen because
gitsaves these directories. Or it might be there for other reasons.Can you please run
git branch && git logon this machine?serhiy-storchaka commentedon Mar 26, 2024
I get now a failure for
test/test_importlib/data. This directory only contains the__pycache__subdirectory. Most likely it is the same in other cases, so with my suggestions #117190 should fix the issue.sobolevn commentedon Mar 26, 2024
Thanks! I just want to make sure that I am able to reproduce all the corner cases 👍
furkanonder commentedon Mar 26, 2024
sobolevn commentedon Mar 26, 2024
Thanks! 👍
gh-117166: Ignore empty and temporary dirs in `test_makefile` (#117190)
pythongh-117166: Ignore empty and temporary dirs in `test_makefile` (p…
Squashed commit of the following:
Squashed commit of the following:
[3.12] gh-117166: Ignore empty and temporary dirs in `test_makefile` (G…
encukou commentedon Apr 3, 2024
Thank you for the report and fix!
pythongh-117166: Ignore empty and temporary dirs in `test_makefile` (p…