test_parserhack in test_future is outdated

Bug report

This test is written for python2.6, which is long gone. It tests some implementation detail with is also long gone:

cpython/Lib/test/test_future_stmt/test_future.py

Lines 174 to 192 in 2cf18a4

    
           def test_parserhack(self): 
        
               # test that the parser.c::future_hack function works as expected 
        
               # Note: although this test must pass, it's not testing the original 
        
               #       bug as of 2.6 since the with statement is not optional and 
        
               #       the parser hack disabled. If a new keyword is introduced in 
        
               #       2.6, change this to refer to the new future import. 
        
               try: 
        
                   exec("from __future__ import print_function; print 0") 
        
               except SyntaxError: 
        
                   pass 
        
               else: 
        
                   self.fail("syntax error didn't occur") 
        
               try: 
        
                   exec("from __future__ import (print_function); print 0") 
        
               except SyntaxError: 
        
                   pass 
        
               else: 
        
                   self.fail("syntax error didn't occur")

We have new tests for print keyword in other modules:

cpython/Lib/test/test_exceptions.py

Lines 176 to 183 in 2cf18a4

    
           s = '''print "old style"''' 
        
           ckmsg(s, "Missing parentheses in call to 'print'. Did you mean print(...)?") 
        
           s = '''print "old style",''' 
        
           ckmsg(s, "Missing parentheses in call to 'print'. Did you mean print(...)?") 
        
           s = 'print f(a+b,c)' 
        
           ckmsg(s, "Missing parentheses in call to 'print'. Did you mean print(...)?")

I propose to remove this test, it does not add any value and might be confusing to readers.

Linked PRs

pythongh-116860: Remove outdated `test_parserhack` from `test_future`

For reference, the tested code was dead since 3.1 (e3944a5).

gh-116860: Remove outdated `test_parserhack` from `test_future` (#116861

pythongh-116860: Remove outdated `test_parserhack` from `test_future` (…

[3.12] gh-116860: Remove outdated `test_parserhack` from `test_future` (

[3.13] gh-116860: Remove outdated `test_parserhack` from `test_future` (

pythongh-116860: Remove outdated `test_parserhack` from `test_future` (…

Navigation Menu

Repository navigation

`test_parserhack` in `test_future` is outdated #116860

Bug report

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	def test_parserhack(self):
	# test that the parser.c::future_hack function works as expected
	# Note: although this test must pass, it's not testing the original
	# bug as of 2.6 since the with statement is not optional and
	# the parser hack disabled. If a new keyword is introduced in
	# 2.6, change this to refer to the new future import.
	try:
	exec("from __future__ import print_function; print 0")
	except SyntaxError:
	pass
	else:
	self.fail("syntax error didn't occur")

	try:
	exec("from __future__ import (print_function); print 0")
	except SyntaxError:
	pass
	else:
	self.fail("syntax error didn't occur")

	s = '''print "old style"'''
	ckmsg(s, "Missing parentheses in call to 'print'. Did you mean print(...)?")

	s = '''print "old style",'''
	ckmsg(s, "Missing parentheses in call to 'print'. Did you mean print(...)?")

	s = 'print f(a+b,c)'
	ckmsg(s, "Missing parentheses in call to 'print'. Did you mean print(...)?")

test_parserhack in test_future is outdated #116860

Description

Bug report

Linked PRs

Activity

serhiy-storchaka commented on Mar 15, 2024

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

`test_parserhack` in `test_future` is outdated #116860