Skip to content

On WASI, time.process_time is not in seconds #115714

Closed
Closed
On WASI, time.process_time is not in seconds#115714
Assignees
encukou
Labels
OS-wasitype-bugAn unexpected behavior, bug, or error

Description

@encukou
encukou
opened on Feb 20, 2024

In a fresh WASI build, time.process_time, which should be in seconds, counts 10⁶ times faster than time.time:

>>> import time
>>> time.time(); time.process_time()
1708435312.596558
4775079350.12
>>> time.time(); time.process_time()
1708435313.0949461
4780063256.54
>>> time.get_clock_info('process_time')
namespace(implementation='clock_gettime(CLOCK_PROCESS_CPUTIME_ID)', monotonic=True, adjustable=False, resolution=1e-09)

It looks like WASI might remove CLOCK_PROCESS_CPUTIME_ID. Should we wait for that? Remove it from Python sooner? Work around the issue?

(Codespaces has an “unexpected error” for me right now, so I built the container from .devcontainer/Dockerfile directly. Hope that doesn't affect the result.)

Linked PRs

Activity

  1. encukou
    added
    OS-wasi
    on Feb 20, 2024

  2. encukou commented on Feb 20, 2024

    @encukou
    encukou
    on Feb 20, 2024
    MemberAuthor

    @brettcannon, your thoughts on this?

  3. AlexWaygood
    added this to Date and time issues 🕰️on Feb 20, 2024

  4. brettcannon commented on Feb 20, 2024

    @brettcannon
    brettcannon
    on Feb 20, 2024
    Member

    We should just remove it.

  5. brettcannon
    added
    type-bugAn unexpected behavior, bug, or error
    on Feb 20, 2024

  6. brettcannon commented on Feb 20, 2024

    @brettcannon
    brettcannon
    on Feb 20, 2024
    Member

    I built the container from .devcontainer/Dockerfile directly. Hope that doesn't affect the result.

    It shouldn't. All Codespaces does on top of that container is inject a git checkout and configures VS Code automatically.

  7. encukou
    self-assigned this
    on Feb 21, 2024

  8. encukou commented on Feb 21, 2024

    @encukou
    encukou
    on Feb 21, 2024
    MemberAuthor

    It turns out the return value of sysconf(_SC_CLK_TCK) (number of clock ticks per second) is incorrect, at least for scaling times from CLOCK_PROCESS_CPUTIME_ID and times().

    I'll prepare a PR that avoids calling them in time.

  9. encukou
    added 2 commits that reference this issue on Feb 21, 2024

    pythongh-115714: Don't use CLOCK_PROCESS_CPUTIME_ID and times() on WASI

    9a41a0b

    gh-115714: Don't use CLOCK_PROCESS_CPUTIME_ID and times() on WASI (GH…

    8aa372e
  10. encukou
    closed this as completedon Feb 22, 2024
  11. github-project-automation
    moved this to Done in Date and time issues 🕰️on Feb 22, 2024

  12. brettcannon commented on Feb 22, 2024

    @brettcannon
    brettcannon
    on Feb 22, 2024
    Member

    Thanks!

  13. woodruffw
    added a commit that references this issue on Mar 4, 2024

    pythongh-115714: Don't use CLOCK_PROCESS_CPUTIME_ID and times() on WA…

    9c68e3c
  14. diegorusso
    added a commit that references this issue on Apr 17, 2024

    pythongh-115714: Don't use CLOCK_PROCESS_CPUTIME_ID and times() on WA…

    7cea3d3
  15. LukasWoodtli
    added a commit that references this issue on Jan 22, 2025

    pythongh-115714: Don't use CLOCK_PROCESS_CPUTIME_ID and times() on WA…

    69aebcd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

OS-wasitype-bugAn unexpected behavior, bug, or error

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions