Repository navigation
test_pdb broken under WASI #114275
Description
Activity
/cc @sobolevn
Hm, I am investigating this 🤔
First of all, it passes locally on macos platform.
Second, here's the failure:
Doctest: test.test_pdb.test_pdb_next_command_for_coroutine ... FAIL test_pdb_next_command_for_generator (test.test_pdb) Doctest: test.test_pdb.test_pdb_next_command_for_generator ... ok test_pdb_next_command_in_generator_for_loop (test.test_pdb) Doctest: test.test_pdb.test_pdb_next_command_in_generator_for_loop ... ok test_pdb_next_command_subiterator (test.test_pdb) Doctest: test.test_pdb.test_pdb_next_command_subiterator ... ok test_pdb_pp_repr_exc (test.test_pdb) Doctest: test.test_pdb.test_pdb_pp_repr_exc ... Warning -- Unraisable exception Exception ignored in: <function BaseEventLoop.__del__ at 0xb453f8> Traceback (most recent call last): File "/Lib/asyncio/base_events.py", line 750, in __del__ self.close() File "/Lib/asyncio/unix_events.py", line 70, in close super().close() File "/Lib/asyncio/selector_events.py", line 104, in close self._close_self_pipe() File "/Lib/asyncio/selector_events.py", line 111, in _close_self_pipe self._remove_reader(self._ssock.fileno()) AttributeError: '_UnixSelectorEventLoop' object has no attribute '_ssock' Warning -- Unraisable exception Exception ignored in: <function BaseEventLoop.__del__ at 0xb453f8> Traceback (most recent call last): File "/Lib/asyncio/base_events.py", line 750, in __del__ self.close() File "/Lib/asyncio/unix_events.py", line 70, in close super().close() File "/Lib/asyncio/selector_events.py", line 104, in close self._close_self_pipe() File "/Lib/asyncio/selector_events.py", line 111, in _close_self_pipe self._remove_reader(self._ssock.fileno()) AttributeError: '_UnixSelectorEventLoop' object has no attribute '_ssock' ok test_pdb_return_command_for_coroutine (test.test_pdb) Doctest: test.test_pdb.test_pdb_return_command_for_coroutine ... FAILThird, no direct import / usage of
test_doctestis there.
Looking further.Ok, I found out what is going on:
test_pdbused to import code fromtest_doctesttest_doctesthasif not support.has_subprocess_support: skip- So, all
test_pdbwas skipped on wasi, proof: https://buildbot.python.org/all/#/builders/1061/builds/694/steps/11/logs/stdio - Now, I removed import from
test_doctest, which is a good thing - It unskipped
test_pdbon WASI
There are several things we can do:
- Skip these failing tests on WASI with a TODO comment
- Skip the whole test file
- Try to fix it (but it is asyncio related and I am not an expert in this module)
I propose to use the same skip that
test_asynciouses for these specific tests.@brettcannon @vstinner what are your thoughts on this?
I suggest to skip again the test which was skipped previously.
- added a commit that references this issue
on Jan 19, 2024 1 remaining item
I was going to say to skip them. 😁 Thanks for the prompt fix!
Reacted by Victor StinnerI had to reopen this as the fix didn't get backported to 3.12 and 3.11.
I had to reopen this as the fix didn't get backported to 3.12 and 3.11.
Alright. I merged the 2 backports, thanks. I close again the issue.
Reacted by Brett Cannon
Bug report
#112109 is the culprit.
https://buildbot.python.org/all/#/builders/1046/builds/4033
https://buildbot.python.org/all/#/builders/1124/builds/623
Linked PRs
Lib/test/test_doctest/(#112109)" #114283asynciointest_pdbfor WASI builds #114309asynciointest_pdbfor WASI builds (GH-114309) #114438asynciointest_pdbfor WASI builds (GH-114309) #114439