Skip to content

Rename Py_NOGIL to a positive term #111863

Closed
Closed
Rename Py_NOGIL to a positive term#111863
Labels
3.13only security fixestopic-free-threading

Description

@hugovk
hugovk
opened on Nov 8, 2023

From the PEP 703 acceptance:

We want to avoid negatives in terms and flags and such, so we won’t get into double-negative terrain (like we do when we talk about ‘non no-GIL’). We’d like a positive, clear term to talk about the no-GIL build, and we’re suggesting ‘free-threaded’. (Relatedly, that’s why the build mode/ABI letter is ‘t’ and not ‘n’; that change was already made.)

Py_NOGIL is a user-facing macro, let's rename it to something positive.

Maybe Py_DISABLE_GIL or Py_FREE_THREADED?

cc @colesbury

Linked PRs

Activity

  1. hugovk
    added
    3.13only security fixes
    topic-free-threading
    on Nov 8, 2023

  2. corona10 commented on Nov 8, 2023

    @corona10
    corona10
    on Nov 8, 2023
    Member

    Maybe it will affect to #111571, Sam may need to make decision what should go first :)
    But I agree with updating the term to follow SC's decision anyway.

  3. hugovk commented on Nov 8, 2023

    @hugovk
    hugovk
    on Nov 8, 2023
    MemberAuthor

    Yep, fully defer to Sam to merge things in whatever order he likes, including closing #111864 if he wants to do it another way.

  4. itamaro commented on Nov 9, 2023

    @itamaro
    itamaro
    on Nov 9, 2023
    Contributor

    up to Sam of course, but perhaps invert it completely, and go with something like Py_GIL or Py_WITH_GIL?

  5. colesbury commented on Nov 9, 2023

    @colesbury
    colesbury
    on Nov 9, 2023
    Contributor

    I commented on @hugovk's PR (#111864 (comment)).

    Macros like Py_GIL or Py_WITH_GIL do not work well because they are not defined in older versions of Python (or pypy). That would make writing the #if pre-processor guards more difficult for extension code that targets multiple versions of Python.

  6. colesbury commented on Nov 9, 2023

    @colesbury
    colesbury
    on Nov 9, 2023
    Contributor

    I put an issue in the steering council GitHub repo: python/steering-council#214

  7. gvanrossum commented on Nov 9, 2023

    @gvanrossum
    gvanrossum
    on Nov 9, 2023
    Member

    I propose "multicore".

  8. hugovk commented on Nov 20, 2023

    @hugovk
    hugovk
    on Nov 20, 2023
    MemberAuthor

    The SC decision: Py_GIL_DISABLED

    I've updated the PR.

  9. hugovk
    added a commit that references this issue on Nov 20, 2023

    gh-111863: Rename `Py_NOGIL` to `Py_GIL_DISABLED` (#111864)

    3b3ec0d
  10. hugovk
    closed this as completedon Nov 20, 2023
  11. scoder
    added 2 commits that reference this issue on Nov 20, 2023

    PEP 703: Accept new `Py_GIL_DISABLED` macro in addition to `PY_NOGIL` (…

    fcd5a49

    PEP 703: Accept new `Py_GIL_DISABLED` macro in addition to `PY_NOGIL` (…

    f258b67
  12. Yhg1s
    added a commit that references this issue on Nov 21, 2023

    gh-111863: Rename blurb snippet placed in the wrong directory by acci…

    4c483e0
  13. corona10
    added 2 commits that reference this issue on Nov 22, 2023

    pythongh-111863: Rename term Py_NOGIL to Py_GIL_DISABLED in sysconfig

    da62f48

    gh-111863: Rename term Py_NOGIL to Py_GIL_DISABLED in sysconfig (gh-1…

    4fa376b
  14. aisk
    added 3 commits that reference this issue on Feb 11, 2024

    pythongh-111863: Rename `Py_NOGIL` to `Py_GIL_DISABLED` (python#111864)

    935eef8

    pythongh-111863: Rename blurb snippet placed in the wrong directory b…

    483da46

    pythongh-111863: Rename term Py_NOGIL to Py_GIL_DISABLED in sysconfig (…

    ad1b186
  15. Glyphack
    added 3 commits that reference this issue on Sep 2, 2024

    pythongh-111863: Rename `Py_NOGIL` to `Py_GIL_DISABLED` (python#111864)

    0a59da0

    pythongh-111863: Rename blurb snippet placed in the wrong directory b…

    de70a60

    pythongh-111863: Rename term Py_NOGIL to Py_GIL_DISABLED in sysconfig (…

    c56aa2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.13only security fixestopic-free-threading

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions