Skip to content

Make _Py_HashDouble public again as "unstable" API #111545

Description

@seberg

In NumPy we use _Py_HashDouble for our floating point hashing needs and that seems like a pretty good candiate for the unstable API to me: #91744 (comment) and #101101 (comment).

However, the function is currently removed rather than made unstable (to my understanding). While it should probably be easy enough to vendor what we needed, I would prefer the unstable API tier, it gives a better sense of having the required identical hashing.

NumPy issue: numpy/numpy#25035

Originally reported by @ngoldbaum in #111418 (comment)

Linked PRs

Activity

  1. encukou commented on Nov 2, 2023

    @encukou
    Member

    cc @vstinner, per the What's New

  2. vstinner commented on Nov 2, 2023

    @vstinner
    Member

    In NumPy we use _Py_HashDouble for our floating point hashing needs and that seems like a pretty good candiate for the unstable API to me: #91744 (comment) and #101101 (comment).

    I would prefer a public API rather than a private API. I don't expect Py_HashDouble() API to be unstable.

    See also issue #111389.

    cc @vstinner, per the What's New

    Thanks. I'm trying to keep track of these issues under #111481 meta issue.

  3. added 11 commits that reference this issue on Nov 14, 2023
  4. 27 remaining items

  5. added 5 commits that reference this issue on Dec 5, 2023
  6. added 4 commits that reference this issue on Feb 11, 2024
  7. vstinner commented on May 19, 2024

    @vstinner
    Member

    It was decided to not add a public API for now: capi-workgroup/decisions#2 (comment)

  8. added 4 commits that reference this issue on Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions