Make _Py_HashDouble public again as "unstable" API #111545
Copy link
Copy link
Closed
Labels
Description
Activity
- addedtype-featureA feature request or enhancementA feature request or enhancement
on Oct 31, 2023 cc @vstinner, per the What's New
In NumPy we use _Py_HashDouble for our floating point hashing needs and that seems like a pretty good candiate for the unstable API to me: #91744 (comment) and #101101 (comment).
I would prefer a public API rather than a private API. I don't expect Py_HashDouble() API to be unstable.
See also issue #111389.
cc @vstinner, per the What's New
Thanks. I'm trying to keep track of these issues under #111481 meta issue.
Reacted by Sebastian Berg- added 11 commits that reference this issue
on Nov 14, 2023 27 remaining items
- added 5 commits that reference this issue
on Dec 5, 2023 - added 4 commits that reference this issue
on Feb 11, 2024 It was decided to not add a public API for now: capi-workgroup/decisions#2 (comment)
- added 4 commits that reference this issue
on Sep 2, 2024
In NumPy we use
_Py_HashDoublefor our floating point hashing needs and that seems like a pretty good candiate for the unstable API to me: #91744 (comment) and #101101 (comment).However, the function is currently removed rather than made unstable (to my understanding). While it should probably be easy enough to vendor what we needed, I would prefer the unstable API tier, it gives a better sense of having the required identical hashing.
NumPy issue: numpy/numpy#25035
Originally reported by @ngoldbaum in #111418 (comment)
Linked PRs