Skip to content

unittest.TestResult.testsRun no longer counts skipped tests. #110890

Closed as not planned
Closed as not planned
unittest.TestResult.testsRun no longer counts skipped tests.#110890
Labels
3.13only security fixesstdlibStandard Library Python modules in the Lib/ directory

Description

@felixxm
felixxm
opened on Oct 15, 2023

Bug report

Bug description:

unittest.TestResult.testsRun no longer counts skipped tests in Python 3.13.0a1. I couldn't not find anything in the release notes, so maybe it's not an intended change 🤔 If it was changed on purpose I can adjust our test. Thanks!

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Activity

  1. felixxm
    added
    type-bugAn unexpected behavior, bug, or error
    on Oct 15, 2023

  2. AlexWaygood commented on Oct 15, 2023

    @AlexWaygood
    AlexWaygood
    on Oct 15, 2023 · Hidden as resolved

  3. felixxm commented on Oct 15, 2023

    @felixxm
    felixxm
    on Oct 15, 2023 · Hidden as resolved
    Author
  4. AlexWaygood
    changed the title [-]TestResult.testsRun no longer counts skipped tests.[/-] [+]unittest.TestResult.testsRun no longer counts skipped tests.[/+] on Oct 15, 2023
  5. AlexWaygood
    added
    stdlibStandard Library Python modules in the Lib/ directory
    3.13only security fixes
    on Oct 15, 2023
  6. AlexWaygood
    added this to Unittest & doctest issueson Oct 15, 2023
  7. github-project-automation
    moved this to Todo in Unittest & doctest issueson Oct 15, 2023
  8. terryjreedy
    removed
    type-bugAn unexpected behavior, bug, or error
    on Oct 15, 2023

  9. terryjreedy commented on Oct 15, 2023

    @terryjreedy
    terryjreedy
    on Oct 15, 2023
    Member

    Intentional change viewed as a bugfix. In the 3.13 changelog changelog:
    gh-106584: Fix exit code for unittest if all tests are skipped.
    The corresponding PR 106588 starts "Increase the number of running tests only if a test hasn't been skipped." This was merged into 3.13 a week before 3.12.0 was released and the backport was deferred until after that release to appear in 3.12.1. In the diff, the call to result.startTest, which increments testsRun, is moved below the skip return with comment "# Increase the number of tests only if it hasn't been skipped".

  10. terryjreedy
    closed this as not plannedon Oct 15, 2023
  11. github-project-automation
    moved this from Todo to Done in Unittest & doctest issueson Oct 15, 2023

  12. felixxm commented on Oct 15, 2023

    @felixxm
    felixxm
    on Oct 15, 2023
    ContributorAuthor

    Intentional change viewed as a bugfix. In the 3.13 changelog changelog: gh-106584: Fix exit code for unittest if all tests are skipped. The corresponding PR 106588 starts "Increase the number of running tests only if a test hasn't been skipped." This was merged into 3.13 a week before 3.12.0 was released and the backport was deferred until after that release to appear in 3.12.1. In the diff, the call to result.startTest, which increments testsRun, is moved below the skip return with comment "# Increase the number of tests only if it hasn't been skipped".

    @terryjreedy Many thanks for the detailed explanation 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.13only security fixesstdlibStandard Library Python modules in the Lib/ directory

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions