Repository navigation
Run ruff on Argument Clinic in CI #110558
Description
Feature or enhancement
Proposal:
As @erlend-aasland and I have worked on adding type hints to Argument Clinic over the last few months, and applied various other modernisations to Tools/clinic/, running pyflakes on the code on a regular basis has caught numerous small bugs that periodically crept in due to a refactoring. Pyflakes has an extremely low number of false positives, so it would be great to have this run as part of CI to catch these issues before they're merged in.
Following #109161, we now run ruff in CI on the Lib/test/ directory, and ruff has implementations of all the pyflakes error codes. I propose that we add a CI check that runs the full set of pyflakes checks (via ruff) on Tools/clinic/.
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
No response
Linked PRs
- gh-110558: Run ruff on Argument Clinic in CI #110559
- [3.12] gh-110558: Run ruff on Argument Clinic in CI (#110559) #110598
- gh-110558: Enable ruff's pyupgrade rules when running on Argument Clinic #110603
- [3.12] gh-110558: Enable ruff's pyupgrade rules when running on Argument Clinic (GH-110603) #110609
Activity
pythongh-110558: Run ruff on Argument Clinic in CI
gh-110558: Run ruff on Argument Clinic in CI (#110559)
[3.12] pythongh-110558: Run ruff on Argument Clinic in CI (python#110559
pythongh-110558: Enable ruff's pyupgrade rules when running on Argume…
pythongh-110558: Enable ruff's pyupgrade rules when running on Argume…
[3.12] gh-110558: Run ruff on Argument Clinic in CI (#110559) (#110598)
gh-110558: Enable ruff's pyupgrade rules when running on Argument Cli…
pythongh-110558: Enable ruff's pyupgrade rules when running on Argume…
[3.12] gh-110558: Enable ruff's pyupgrade rules when running on Argum…
pythongh-110558: Run ruff on Argument Clinic in CI (python#110559)
pythongh-110558: Enable ruff's pyupgrade rules when running on Argume…