Skip to content

test__xxinterpchannels leaks [21, 21, 21] references #110300

Closed
Closed
test__xxinterpchannels leaks [21, 21, 21] references#110300
Assignees
ericsnowcurrently
Labels
testsTests in the Lib/test dirtopic-subinterpreterstype-bugAn unexpected behavior, bug, or error

Description

@vstinner
vstinner
opened on Oct 3, 2023
./python -m test test__xxinterpchannels -R 3:3
(...)
test__xxinterpchannels leaked [21, 21, 21] references, sum=63

Regression introduced by: commit a8f5dab

commit a8f5dab58daca9f01ec3c6f8c85e53329251b05d
Author: Eric Snow <ericsnowcurrently@gmail.com>
Date:   Mon Oct 2 14:47:41 2023 -0600

    gh-76785: Module-level Fixes for test.support.interpreters (gh-110236)
    
    * add RecvChannel.close() and SendChannel.close()
    * make RecvChannel and SendChannel shareable
    * expose ChannelEmptyError and ChannelNotEmptyError

 Lib/test/support/interpreters.py  |  30 +++++--
 Lib/test/test_interpreters.py     |  16 ++++
 Modules/_xxinterpchannelsmodule.c | 185 +++++++++++++++++++++++++++++++++-----
 3 files changed, 206 insertions(+), 25 deletions(-)

Example of build: https://buildbot.python.org/all/#/builders/320/builds/855

cc @ericsnowcurrently

Linked PRs

Activity

  1. vstinner
    added
    testsTests in the Lib/test dir
    on Oct 3, 2023
  2. AlexWaygood
    added
    topic-subinterpreters
    on Oct 3, 2023
  3. github-project-automation
    added this to Subinterpreterson Oct 3, 2023
  4. github-project-automation
    moved this to Todo in Subinterpreterson Oct 3, 2023

  5. ericsnowcurrently commented on Oct 3, 2023

    @ericsnowcurrently
    ericsnowcurrently
    on Oct 3, 2023
    Member

    FWIW, test_interpreters has much worst leaks. They are due to _xxinterpchannels._register_end_types(). I'm going to temporarily drop that call and circle back to what's causing the leaks there.

  6. ericsnowcurrently
    added a commit that references this issue on Oct 4, 2023

    gh-110300: Fix Refleaks in test_interpreters and test__xxinterpchanne…

    269005e
  7. ericsnowcurrently
    self-assigned this
    on Oct 4, 2023

  8. ericsnowcurrently commented on Oct 4, 2023

    @ericsnowcurrently
    ericsnowcurrently
    on Oct 4, 2023
    Member

    I've merged a temporary fix, but I still need to resolve the underlying issue.

  9. vstinner commented on Oct 4, 2023

    @vstinner
    vstinner
    on Oct 4, 2023
    MemberAuthor

    ./python -m test test__xxinterpchannels -R 3:3 no longer leaks, I close the issue.

  10. vstinner
    closed this as completedon Oct 4, 2023
  11. github-project-automation
    moved this from Todo to Done in Subinterpreterson Oct 4, 2023
  12. ericsnowcurrently
    added
    type-bugAn unexpected behavior, bug, or error
    on Feb 27, 2024

  13. ericsnowcurrently commented on Jun 18, 2024

    @ericsnowcurrently
    ericsnowcurrently
    on Jun 18, 2024
    Member

    FTR, I followed up on gh-110607.

  14. Glyphack
    added a commit that references this issue on Sep 2, 2024

    pythongh-110300: Fix Refleaks in test_interpreters and test__xxinterp…

    4e072be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

testsTests in the Lib/test dirtopic-subinterpreterstype-bugAn unexpected behavior, bug, or error

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions