Repository navigation
Run mypy on Tools/wasm #109125
Description
Feature or enhancement
Right now we already have 3 fully typed and checked tools:
- Add type annotations to clinic.py #104050
- Run
mypyonTools/peg_generator#108455 - Run
mypyoncases_generator#104504
I think we can also add Tools/wasm quite easily to this list.
Tools/wasm already has most of the type annotations, but there are some mypy errors to fix.
Activity
pythongh-109125: Run mypy on `Tools/wasm`
brettcannon commentedon Sep 8, 2023
I'm not sure if it's worth keeping a couple of scripts typed, especially based on the restrictions of typing in the repo (e.g., older versions of Python w/o
typing_extensionsaccess, etc.). I honestly would be fine stripping out the types in the scripts in that directory rather than try to keep the types working.corona10 commentedon Sep 10, 2023
We may need to define the scope of what scripts would be worth adding typing, and applying mypy pipeline.
cc @AlexWaygood @erlend-aasland @vstinner
AlexWaygood commentedon Sep 10, 2023
I'm not sure this needs to be formalised much. I think we should add mypy to CI for self-contained CPython projects where the maintainers of those projects say they'd find it useful. We should avoid doing so for projects where the maintainers of those projects say it wouldn't be useful.
vstinner commentedon Sep 10, 2023
Once I will be done with refactoring libregrtest #109162 I will need help to add type hints there ;-) IMO it would be a more interesting target than Tools/wasm/ scripts.
gh-109125: Run mypy on `Tools/wasm` (#109126)
[3.12] pythongh-109125: Run mypy on `Tools/wasm` (pythonGH-109126)
hugovk commentedon Sep 19, 2023
Done via #109126, thanks!
pythongh-109125: Run mypy on `Tools/wasm` (python#109126)