Skip to content

Use Kyiv instead of Kiev in test_email #109017

Closed
Closed
Use Kyiv instead of Kiev in test_email#109017
Assignees
serhiy-storchaka
Labels
type-bugAn unexpected behavior, bug, or error

Description

@jspricke
jspricke
opened on Sep 6, 2023

Bug report

Bug description:

As proposed in #108533 the time zone was renamed but we can't simply rename it in the test cause it fails on old(?) MacOS systems. I would propose to prepend it with:

@unittest.skipUnless(os.path.exists('/usr/share/zoneinfo/Europe/Kyiv') or
                         os.path.exists('/usr/lib/zoneinfo/Europe/Kyiv'),
                         "Can't find the Olson's TZ database")

CPython versions tested on:

3.11

Operating systems tested on:

Linux

Linked PRs

Activity

  1. jspricke
    added
    type-bugAn unexpected behavior, bug, or error
    on Sep 6, 2023

  2. corona10 commented on Sep 10, 2023

    @corona10
    corona10
    on Sep 10, 2023
    Member

    @serhiy-storchaka Would you like to take a look since you are the Ukranian?

  3. jspricke
    added 2 commits that reference this issue on Sep 11, 2023

    Use non alternate name for Kyiv (Fixes: python#109017)

    9026723

    pythongh-109017: Use non alternate name for Kyiv

    43a38cf
  4. serhiy-storchaka
    self-assigned this
    on Sep 11, 2023

  5. serhiy-storchaka commented on Sep 11, 2023

    @serhiy-storchaka
    serhiy-storchaka
    on Sep 11, 2023
    Member

    I do not like relying on the particular location of the database. Although it was already here in the existing code, the comment notes that it is not a robust way. Now we have zoneinfo in the stdlib, so perhaps it could be used.

  6. jspricke
    added a commit that references this issue on Sep 11, 2023

    pythongh-109017: Use non alternate name for Kyiv

    f7545ea

  7. jspricke commented on Sep 11, 2023

    @jspricke
    jspricke
    on Sep 11, 2023
    ContributorAuthor

    @serhiy-storchaka thanks for the proposal, I've updated my PR.

  8. jspricke
    added a commit that references this issue on Sep 11, 2023

    pythongh-109017: Use non alternate name for Kyiv

    b10798b
  9. serhiy-storchaka
    added a commit that references this issue on Oct 24, 2023

    gh-109017: Use non alternate name for Kyiv (GH-109251)

    46407fe
  10. miss-islington
    added 2 commits that reference this issue on Oct 24, 2023

    pythongh-109017: Use non alternate name for Kyiv (pythonGH-109251)

    59db316

    pythongh-109017: Use non alternate name for Kyiv (pythonGH-109251)

    1b56294
  11. serhiy-storchaka
    added 2 commits that reference this issue on Oct 24, 2023

    [3.12] gh-109017: Use non alternate name for Kyiv (GH-109251) (GH-111280

    b6e508c

    [3.11] gh-109017: Use non alternate name for Kyiv (GH-109251) (GH-111279

    652d3f3
  12. serhiy-storchaka
    closed this as completedon Oct 24, 2023
  13. aisk
    added a commit that references this issue on Feb 11, 2024

    pythongh-109017: Use non alternate name for Kyiv (pythonGH-109251)

    ac32394
  14. Glyphack
    added a commit that references this issue on Sep 2, 2024

    pythongh-109017: Use non alternate name for Kyiv (pythonGH-109251)

    8fbaa03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

type-bugAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions