Repository navigation
test_tomllib.test_inline_array_recursion_limit() failed on wasm32-wasi 3.11 buildbot #108851
Description
test_tomllib.test_inline_array_recursion_limit() failed on wasm32-wasi 3.11 buildbot:
ERROR: test_inline_array_recursion_limit (test.test_tomllib.test_misc.TestMiscellaneous.test_inline_array_recursion_limit)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Lib/test/test_tomllib/test_misc.py", line 98, in test_inline_array_recursion_limit
tomllib.loads(recursive_array_toml)
File "/Lib/tomllib/_parser.py", line 102, in loads
pos = key_value_rule(src, pos, out, header, parse_float)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Lib/tomllib/_parser.py", line 326, in key_value_rule
pos, key, value = parse_key_value_pair(src, pos, parse_float)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Lib/tomllib/_parser.py", line 369, in parse_key_value_pair
pos, value = parse_value(src, pos, parse_float)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Lib/tomllib/_parser.py", line 616, in parse_value
return parse_array(src, pos, parse_float)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Lib/tomllib/_parser.py", line 420, in parse_array
pos, val = parse_value(src, pos, parse_float)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
(...)
File "/Lib/tomllib/_parser.py", line 416, in parse_array
pos = skip_comments_and_array_ws(src, pos)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Lib/tomllib/_parser.py", line 278, in skip_comments_and_array_ws
pos = skip_chars(src, pos, TOML_WS_AND_NEWLINE)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
RecursionError: maximum recursion depth exceeded
link: https://buildbot.python.org/all/#/builders/1047/builds/908
Activity
pythongh-108851: Add support.get_recursion_available()
pythongh-108851: Add support.get_recursion_available()
pythongh-108851: Add support.get_recursion_available()
pythongh-108851: Fix tomllib recusion tests
pythongh-108851: Fix tomllib recursion tests
pythongh-108851: Fix tomllib recursion tests
pythongh-108851: Fix tomllib recursion tests
pythongh-108851: Fix tomllib recursion tests
pythongh-108851: Fix tomllib recursion tests
pythongh-108851: Fix tomllib recursion tests
gh-108851: Fix tomllib recursion tests (#108853)
pythongh-108851: Fix tomllib recursion tests (pythonGH-108853)
1 remaining item
pythongh-108851: Fix tomllib recursion tests (python#108853)
[3.11] gh-108851: Fix tomllib recursion tests (#108853) (#109013)
[3.12] gh-108851: Fix tomllib recursion tests (GH-108853) (#109012)
pythongh-108851: Fix support.get_recursion_available() for USE_STACKC…
[3.11] gh-108851: Fix support.get_recursion_available() for USE_STACK…
markshannon commentedon Nov 18, 2023
I don't understand what's going on here.
Why does the test fail?
Hacking the tests does not seem to be the right solution. Why not fix the underlying problem, or at least triage it first?
markshannon commentedon Nov 18, 2023
My mistake. I didn't see the all important
3.11part.Still, we ought to record what the problem is on the issue, before fixing it.
markshannon commentedon Nov 18, 2023
So, why change 3.13 and 3.12, if this is a 3.11 issue?
vstinner commentedon Nov 27, 2023
First I saw the issue on 3.11, but in fact the 3 branches were affectected: 3.11, 3.12 and main.
@markshannon: Did you reopen the issue because you want to make changes?
brettcannon commentedon Dec 14, 2023
Since all the buildbots are passing, I'm closing the issue as fixed.