Skip to content

test_curses has duplicated tests #106194

Closed
Closed
test_curses has duplicated tests#106194
Assignees
sobolevn
Labels
testsTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or error

Description

@sobolevn
sobolevn
opened on Jun 28, 2023

From python/core-workflow#505

Lib/test/test_curses.py:1371:5: F811 redefinition of unused 'test_move_left' from line 1362

Source:

cpython/Lib/test/test_curses.py

Lines 1362 to 1376 in bbf722d

def test_move_left(self):
"""Test moving the cursor left."""
self.mock_win.reset_mock()
self.textbox.do_command(curses.KEY_LEFT)
self.mock_win.move.assert_called_with(1, 0)
self.textbox.do_command(curses.KEY_RIGHT)
self.mock_win.move.assert_called_with(1, 2)
self.mock_win.reset_mock()
def test_move_left(self):
"""Test moving the cursor left."""
self.mock_win.reset_mock()
self.textbox.do_command(curses.KEY_RIGHT)
self.mock_win.move.assert_called_with(1, 2)
self.mock_win.reset_mock()

Based on a context, I think they should be renamed to test_move_left and test_move_right.

Linked PRs

Activity

  1. sobolevn
    added
    type-bugAn unexpected behavior, bug, or error
    testsTests in the Lib/test dir
    on Jun 28, 2023
  2. sobolevn
    self-assigned this
    on Jun 28, 2023
  3. sobolevn
    added a commit that references this issue on Jun 28, 2023

    pythongh-106194: Rename duplicated tests in `test_curses`

    7e8da24
  4. hugovk
    added a commit that references this issue on Jun 28, 2023

    gh-106194: Rename duplicated tests in `test_curses` (#106196)

    3fb7c60
  5. miss-islington
    added a commit that references this issue on Jun 28, 2023

    pythongh-106194: Rename duplicated tests in `test_curses` (pythonGH-1…

    ae98dbe
  6. hugovk
    added a commit that references this issue on Jun 28, 2023

    [3.12] gh-106194: Rename duplicated tests in `test_curses` (GH-106196) (

    e12045d
  7. serhiy-storchaka
    closed this as completedon Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

testsTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions