Skip to content

test_monitoring has duplicated tests #106193

Closed

Description

@sobolevn

Based on python/core-workflow#505 by @hugovk

Lib/test/test_monitoring.py:973:5: F811 redefinition of unused 'test_line_then_instruction' from line 950
Lib/test/test_monitoring.py:978:5: F811 redefinition of unused 'test_instruction_then_line' from line 955

Before rename: Ran 49 tests in 0.014s
After rename:

======================================================================
ERROR: test_instruction_then_line (test.test_monitoring.TestInstallIncrementallly.test_instruction_then_line)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/sobolev/Desktop/cpython/Lib/test/test_monitoring.py", line 956, in test_instruction_then_line
    recorders = [ InstructionRecorder, LineRecorderLowNoise ]
                                       ^^^^^^^^^^^^^^^^^^^^
NameError: name 'LineRecorderLowNoise' is not defined

======================================================================
ERROR: test_line_then_instruction (test.test_monitoring.TestInstallIncrementallly.test_line_then_instruction)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/sobolev/Desktop/cpython/Lib/test/test_monitoring.py", line 953, in test_line_then_instruction
    recorders = recorders, must_include = self.EXPECTED_LI)
                                          ^^^^^^^^^^^^^^^^
AttributeError: 'TestInstallIncrementallly' object has no attribute 'EXPECTED_LI'

----------------------------------------------------------------------
Ran 51 tests in 0.045s

FAILED (errors=2)
test test_monitoring failed
test_monitoring failed (2 errors)

== Tests result: FAILURE ==

1 test failed:
    test_monitoring

Total duration: 94 ms
Tests result: FAILURE

Based on the missing runtime parts in these tests, we can just remove the first two ones, I guess.

Both of these tests were introduced in 411b169 by @markshannon

Linked PRs

Activity

  1. added
    type-bugAn unexpected behavior, bug, or error
    testsTests in the Lib/test dir
    on Jun 28, 2023
  2. self-assigned this
    on Jun 28, 2023
  3. sobolevn commented on Jun 28, 2023

    @sobolevn
    MemberAuthor

    No, they cannot be just deleted, because they test different things.

  4. sobolevn commented on Jun 29, 2023

    @sobolevn
    MemberAuthor

    Introduced in b32a075#diff-15fb0cb29709c04c449bacd69e4ab2208372424d8390c26258eb83b2363c3cf1

    Looks like it never had parts that are missing right now.

  5. added
    3.12only security fixes
    3.13only security fixes
    on Sep 8, 2023
  6. hugovk commented on Sep 8, 2023

    @hugovk
    Member

    Please see PR #109139.

  7. added a commit that references this issue on Oct 12, 2023
  8. added 2 commits that reference this issue on Oct 15, 2023
  9. added a commit that references this issue on Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

3.12only security fixes3.13only security fixestestsTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions