Skip to content

test_traceback does not run one set of CPythonTracebackErrorCaretTests #106185

Closed
Closed
test_traceback does not run one set of CPythonTracebackErrorCaretTests#106185
Assignees
sobolevn
Labels
testsTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or error

Description

@sobolevn
sobolevn
opened on Jun 28, 2023

Based on @hugovk work in python/core-workflow#505 I found that we have two duplicated class CPythonTracebackErrorCaretTests here:

cpython/Lib/test/test_traceback.py

Lines 908 to 928 in a3dd8cc

@cpython_only
@requires_debug_ranges()
class CPythonTracebackErrorCaretTests(
CAPIExceptionFormattingMixin,
TracebackErrorLocationCaretTestBase,
unittest.TestCase,
):
"""
Same set of tests as above but with Python's internal traceback printing.
"""
@cpython_only
@requires_debug_ranges()
class CPythonTracebackErrorCaretTests(
CAPIExceptionFormattingLegacyMixin,
TracebackErrorLocationCaretTestBase,
unittest.TestCase,
):
"""
Same set of tests as above but with Python's legacy internal traceback printing.
"""

So, first tests are not executed.
We need to rename on of them.

Before: Ran 236 tests in 2.453s
After: Ran 259 tests in 2.481s

Linked PRs

Activity

  1. sobolevn
    added
    type-bugAn unexpected behavior, bug, or error
    testsTests in the Lib/test dir
    on Jun 28, 2023
  2. sobolevn
    self-assigned this
    on Jun 28, 2023
  3. sobolevn
    added a commit that references this issue on Jun 28, 2023

    pythongh-106185: Deduplicate `CPythonTracebackErrorCaretTests` in `te…

    5f593c8
  4. serhiy-storchaka
    added a commit that references this issue on Jul 25, 2023

    gh-106185: Deduplicate `CPythonTracebackErrorCaretTests` in `test_tra…

    7c89f11
  5. miss-islington
    added a commit that references this issue on Jul 25, 2023

    pythongh-106185: Deduplicate `CPythonTracebackErrorCaretTests` in `te…

    813196e
  6. serhiy-storchaka
    added a commit that references this issue on Jul 25, 2023

    [3.12] gh-106185: Deduplicate `CPythonTracebackErrorCaretTests` in `t…

    3d15c8b
  7. jtcave
    added a commit that references this issue on Jul 27, 2023

    pythongh-106185: Deduplicate `CPythonTracebackErrorCaretTests` in `te…

    eb78ff9

  8. hauntsaninja commented on Sep 7, 2023

    @hauntsaninja
    hauntsaninja
    on Sep 7, 2023
    Contributor

    Nice spot, thank you!

  9. hauntsaninja
    closed this as completedon Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

testsTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions