Skip to content

PyDict_GetItem and PyObject_HasAttr should not be used #106033

Closed
Closed
PyDict_GetItem and PyObject_HasAttr should not be used#106033
Labels
type-bugAn unexpected behavior, bug, or error

Description

@serhiy-storchaka
serhiy-storchaka
opened on Jun 23, 2023

These functions are broken by design, because they discard any exceptions raised inside, including MemoryError and KeyboardInterrupt. There were several rounds of getting rid of them in past (for example 567eba1, #11112, #75753), but they occur in new code.

Linked PRs

Activity

  1. serhiy-storchaka
    added
    type-bugAn unexpected behavior, bug, or error
    on Jun 23, 2023
  2. serhiy-storchaka
    added 5 commits that reference this issue on Jun 23, 2023

    pythongh-106033: Get rid of new occurrences of PyDict_GetItem and PyO…

    c593435

    gh-106033: Get rid of new occurrences of PyDict_GetItem and PyObject_…

    1d33d53

    [3.11] pythongh-106033: Get rid of new occurrences of PyDict_GetItem …

    11c3096

    [3.12] pythongh-106033: Get rid of new occurrences of PyDict_GetItem …

    4224df2

    pythongh-106033: Get rid of PyDict_GetItem in _PyFunction_FromConstru…

    857ec72
  3. gpshead
    added a commit that references this issue on Jun 24, 2023

    gh-106033: [docs] Improve C API GetItem & HasAttr notes. (#106047)

    19d6511
  4. miss-islington
    added 2 commits that reference this issue on Jun 24, 2023

    pythongh-106033: [docs] Improve C API GetItem & HasAttr notes. (pytho…

    eabb664

    pythongh-106033: [docs] Improve C API GetItem & HasAttr notes. (pytho…

    c191574
  5. gpshead
    added 4 commits that reference this issue on Jun 24, 2023

    [3.11] gh-106033: [docs] Improve C API GetItem & HasAttr notes. (GH-1…

    c69f29f

    [3.12] gh-106033: [docs] Improve C API GetItem & HasAttr notes. (GH-1…

    746c0f3

    [3.12] gh-106033: Get rid of new occurrences of PyDict_GetItem and Py… (

    9cd3664

    [3.11] gh-106033: Get rid of new occurrences of PyDict_GetItem and Py… (

    dbe416b
  6. serhiy-storchaka
    added a commit that references this issue on Jun 29, 2023

    gh-106033: Get rid of PyDict_GetItem in _PyFunction_FromConstructor (G…

    08c08d2
  7. miss-islington
    added a commit that references this issue on Jun 29, 2023

    pythongh-106033: Get rid of PyDict_GetItem in _PyFunction_FromConstru…

    aba4a91
  8. serhiy-storchaka
    added a commit that references this issue on Jun 29, 2023

    [3.12] gh-106033: Get rid of PyDict_GetItem in _PyFunction_FromConstr…

    e0fa531

  9. iritkatriel commented on Jun 30, 2023

    @iritkatriel
    iritkatriel
    on Jun 30, 2023
    Member

    See also #86172.

  10. vstinner commented on Jun 30, 2023

    @vstinner
    vstinner
    on Jun 30, 2023
    Member

    See also the issue #106004: I propose adding PyDict_GetItemRef() function which doesn't have these flaws.

  11. erlend-aasland commented on Jul 20, 2023

    @erlend-aasland
    erlend-aasland
    on Jul 20, 2023
    Contributor

    Can this be closed, or do you expect more work here, @serhiy-storchaka?

  12. serhiy-storchaka
    closed this as completedon Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions