Skip to content

Make: multibyte codecs lack dependencies #103527

Closed
#103528
Closed
Make: multibyte codecs lack dependencies#103527
#103528
Assignees
erlend-aasland
Labels
buildThe build process and cross-buildtype-bugAn unexpected behavior, bug, or error

Description

@erlend-aasland
erlend-aasland
opened on Apr 13, 2023

There are no dependencies for the _codec_* and _multibytecodec modules, so if you're hacking away on a header file in Modules/cjkcodecs/ and execute make, you're not going to get a correct rebuild of those extension modules.

Linked PRs

Activity

  1. erlend-aasland
    added
    type-bugAn unexpected behavior, bug, or error
    buildThe build process and cross-build
    on Apr 13, 2023
  2. erlend-aasland
    self-assigned this
    on Apr 13, 2023
  3. erlend-aasland
    added a commit that references this issue on Apr 13, 2023

    pythongh-103527: Add make deps for _codecs_* and _multibytecodec

    f5f39fe
  4. erlend-aasland
    linked a pull request that will close this issuegh-103527: Add make deps for _codecs_* and _multibytecodec #103528on Apr 13, 2023
  5. erlend-aasland
    closed this as completedin #103528on Apr 14, 2023
  6. erlend-aasland
    added 2 commits that reference this issue on Apr 14, 2023

    gh-103527: Add make deps for _codecs_* and _multibytecodec (#103528)

    3d71b5e

    pythongh-103527: Add multibytecodec.h as make dep for _codecs_*

    3ea471f
  7. erlend-aasland
    reopened this on Apr 15, 2023

  8. erlend-aasland commented on Apr 15, 2023

    @erlend-aasland
    erlend-aasland
    on Apr 15, 2023
    ContributorAuthor

    The _codecs_* extension modules all depend on multibytecodec.h. Reopening until fixed.

  9. erlend-aasland
    added a commit that references this issue on Apr 16, 2023

    gh-103527: Add multibytecodec.h as make dep for _codecs_* (#103567)

    a210cac
  10. erlend-aasland
    closed this as completedon Apr 16, 2023
  11. carljm
    added 2 commits that reference this issue on Apr 17, 2023

    Merge branch 'main' into superopt

    5136459

    Merge branch 'superopt' into superopt_spec

    079c65a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

buildThe build process and cross-buildtype-bugAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions