Skip to content

Duplicate #include directives in multiple C files #102650

Closed
#102651
Closed
Duplicate #include directives in multiple C files#102650
#102651
Labels
type-bugAn unexpected behavior, bug, or error

Description

@chgnrdv
chgnrdv
opened on Mar 13, 2023

These are examples of duplicate #include directives that, as far as I can see, do not cause any side effects and therefore can be freely removed (although I have doubts about few cases):

cpython/Mac/Tools/pythonw.c

Line 30 in 634cb61

#include <Python.h>

cpython/Modules/_hashopenssl.c

Line 40 in 634cb61

#include <openssl/crypto.h> // FIPS_mode()

cpython/Modules/arraymodule.c

Line 16 in 634cb61

#include <stddef.h>

cpython/Modules/signalmodule.c

Line 31 in 634cb61

#include "pycore_signal.h" // Py_NSIG

cpython/Programs/_testembed.c

Line 12 in 634cb61

#include <Python.h>

The PR is on the way.

Linked PRs

Activity

  1. chgnrdv
    added
    type-bugAn unexpected behavior, bug, or error
    on Mar 13, 2023
  2. carljm
    closed this as completedin #102651on Mar 13, 2023
  3. carljm
    added 2 commits that reference this issue on Mar 13, 2023

    gh-102650: Remove duplicate include directives from multiple source f…

    85ba8a3

    Merge branch 'main' into inlinecomp2

    6c5f269
  4. Fidget-Spinner
    added a commit that references this issue on Mar 27, 2023

    pythongh-102650: Remove duplicate include directives from multiple so…

    5814088
  5. warsaw
    added a commit that references this issue on Apr 11, 2023

    pythongh-102650: Remove duplicate include directives from multiple so…

    3519886
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions