Repository navigation
blake2-config.h HAVE_SSE4_1 typo fix #102027
Copy link
Copy link
Closed
Labels
buildThe build process and cross-buildThe build process and cross-buildextension-modulesC modules in the Modules dirC modules in the Modules dirtopic-SSLtype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
Description
Activity
- addedtype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
on Feb 18, 2023 - addedextension-modulesC modules in the Modules dirC modules in the Modules dirbuildThe build process and cross-buildThe build process and cross-build
on Feb 18, 2023 @tiran Can you verify that the proposed blake2 typo fix is correct?
EDIT: Looking at the file, I see that lines 49-51 being, in main,
#ifdef HAVE_AVX #ifndef HAVE_SSE4_1 #define HAVE_SSE4_1makes it likely that line 56 should be
#ifndef HAVE_SSE4_1instead of#ifndef HAVE_SSE41.@ambv Do build issues like this get backported to 'security' versions?
@nono303 We close bugfix issues after the corresponding PR is backported to previous versions, just to not lose track.
Reacted by nono303- added a commit that references this issue
on Mar 22, 2023 But this fix hasn't merged into branch 3.9 and lower, people who want to build version before 3.10 still got this bug.
This is standard. Non-security bugfixs are essentially never backported by us to versions that only get security-fixes.
Metadata
Metadata
Assignees
Labels
buildThe build process and cross-buildThe build process and cross-buildextension-modulesC modules in the Modules dirC modules in the Modules dirtopic-SSLtype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
Bug report
Unable to compile cpython on Windows with
AVXenable<EnableEnhancedInstructionSet>AdvancedVectorExtensions</EnableEnhancedInstructionSet>for</ClCompile>in vcxproj files (result/arch:AVXin cl.exe cmd line)MSBuild.exe C:\sdk\src\python\PCbuild\pcbuild.proj /nologo /nr:false /m:16 /p:Turbo=true /p:CL_MPCount=16 /p:RunCodeAnalysis=false /p:DebugType=None /p:DebugSymbols=true /p:WindowsTargetPlatformVersion=10.0.22621.0 /p:PlatformToolset=v143 /clp:EnableMPLogging;Summary;ShowCommandLine /v:d /p:Configuration=Release /p:Platform="x64" /p:IncludeExtensions=true /p:IncludeExternals=true /p:IncludeTests=false /p:IncludeCTypes=true /p:IncludeSSL=true /p:IncludeTkinter=false /p:IncludeUwp=true /t:RebuildAll /p:EXTERNALS_DIR="C:\sdk\release\vs17_x64-avx" /p:ExternalsSrcDir="C:\sdk\src" /p:_DLLSuffix=-81_3-x64 /p:SqliteVersionStrToParse=3.40.1.0 /nowarn:C4244It's just a typo issue in
Modules/_blake2/impl/blake2-config.hThe patch fix the issue
Seems to be present on every branch
Your environment
Linked PRs