Potential memory leak in Objects/bytesobject.c

Bug report

Lines 429 to 443 in 206f05a

    
           p = PyOS_double_to_string(x, type, prec, dtoa_flags, NULL); 
        
           if (p == NULL) 
        
               return NULL; 
        
           len = strlen(p); 
        
           if (writer != NULL) { 
        
               str = _PyBytesWriter_Prepare(writer, str, len); 
        
               if (str == NULL) 
        
                   return NULL; 
        
               memcpy(str, p, len); 
        
               PyMem_Free(p); 
        
               str += len; 
        
               return str; 
        
           }

At line 438, object p won't be freed if _PyBytesWriter_Prepare fails (returns NULL) and thus become a memory leak.

Linked PRs

pythongh-101056: Fix memory leak in `formatfloat()` in `bytesobject.c`

@RuiliF

Good catch! @RuiliF thanks a lot!

How do you detect it? Do you use some kind of tooling? Or just by hand? :)

@RuiliF

Good catch! @RuiliF thanks a lot!

How do you detect it? Do you use some kind of tooling? Or just by hand? :)

Thank you for the quick response! I found it just by hand. :)

If you have others to report - you are more than welcome! 👍

gh-101056: Fix memory leak in `formatfloat()` in `bytesobject.c` (#10…

pythongh-101056: Fix memory leak in `formatfloat()` in `bytesobject.c` (

gh-101056: Fix memory leak in `formatfloat()` in `bytesobject.c` (GH-…

Done!

Navigation Menu

Repository navigation

Potential memory leak in Objects/bytesobject.c #101056

Bug report

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	p = PyOS_double_to_string(x, type, prec, dtoa_flags, NULL);

	if (p == NULL)
	return NULL;

	len = strlen(p);
	if (writer != NULL) {
	str = _PyBytesWriter_Prepare(writer, str, len);
	if (str == NULL)
	return NULL;
	memcpy(str, p, len);
	PyMem_Free(p);
	str += len;
	return str;
	}

Potential memory leak in Objects/bytesobject.c #101056

Description

Bug report

Linked PRs

Activity

sobolevn commented on Jan 15, 2023

RuiliF commented on Jan 15, 2023

sobolevn commented on Jan 15, 2023

sobolevn commented on Jan 17, 2023

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions