Potential memory leak in Parser/parser.c

Bug report

In Parse/parse.c, function _loop0_1_rule (line 23809), object _children

  if (_n == _children_capacity) {
      _children_capacity *= 2;
      void **_new_children = PyMem_Realloc(_children, _children_capacity*sizeof(void *));
      if (!_new_children) {
          p->error_indicator = 1;
          PyErr_NoMemory();
          p->level--;
          return NULL; 
      }     
      _children = _new_children;
  }

If PyMem_Realloc fails, the original object will be kept untouched. Thus returning NULL without free'ing _children will cause a memory leak.

Your environment

Python 3.12

Linked PRs

pythongh-101046: Fix a potential memory leak in the parser when raisi…

@RuiliF

Thanks for opening the issue @RuiliF, unfortunate #101049 just changes a single rule while all rules are subjected to this. I have created a PR fixing this correctly in #101051.

fixup! pythongh-101046: Fix a potential memory leak in the parser whe…

gh-101046: Fix a potential memory leak in the parser when raising Mem…

[3.11] pythongh-101046: Fix a potential memory leak in the parser whe…

[3.10] pythongh-101046: Fix a potential memory leak in the parser whe…

[3.10] gh-101046: Fix a potential memory leak in the parser when rais…

[3.11] gh-101046: Fix a potential memory leak in the parser when rais…

Navigation Menu

Repository navigation

Potential memory leak in Parser/parser.c #101046

Bug report

Your environment

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Potential memory leak in Parser/parser.c #101046

Description

Bug report

Your environment

Linked PRs

Activity

pablogsal commented on Jan 15, 2023

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions