Skip to content

Implement Multi-Phase Init for the _testinternalcapi Module #100997

Closed
Closed
Implement Multi-Phase Init for the _testinternalcapi Module#100997
Labels
3.12only security fixesextension-modulesC modules in the Modules dirtopic-subinterpreterstype-featureA feature request or enhancement

Description

@ericsnowcurrently
ericsnowcurrently
opened on Jan 12, 2023

See PEP 630 and PEP 687. This is an internal test module so the bar isn't as high as for regular stdlib modules.

Linked PRs

Activity

  1. ericsnowcurrently
    added
    type-featureA feature request or enhancement
    extension-modulesC modules in the Modules dir
    topic-subinterpreters
    3.12only security fixes
    on Jan 12, 2023
  2. ezio-melotti
    added this to Subinterpreterson Jan 12, 2023
  3. ericsnowcurrently
    added a commit that references this issue on Jan 12, 2023

    GH-100997: Implement Multi-Phase Init for the _testinternalcapi Module (

    b511d35
  4. ericsnowcurrently
    closed this as completedon Jan 12, 2023
  5. github-project-automation
    moved this to Done in Subinterpreterson Jan 12, 2023

  6. kumaraditya303 commented on Jan 15, 2023

    @kumaraditya303
    kumaraditya303
    on Jan 15, 2023
    Contributor

    With #100998 there are refleaks on main, reopening.

  7. kumaraditya303
    reopened this on Jan 15, 2023
  8. kumaraditya303
    added a commit that references this issue on Jan 16, 2023

    GH-100997: fix refleak in `_testinternalcapi.c` (#101058)

    74c20b6

  9. ericsnowcurrently commented on Jan 18, 2023

    @ericsnowcurrently
    ericsnowcurrently
    on Jan 18, 2023
    MemberAuthor

    The leak is fixed now, right?

  10. kumaraditya303 commented on Jan 18, 2023

    @kumaraditya303
    kumaraditya303
    on Jan 18, 2023
    Contributor

    Yeah fixed by #101058

  11. kumaraditya303
    closed this as completedon Jan 18, 2023

  12. ericsnowcurrently commented on Jan 18, 2023

    @ericsnowcurrently
    ericsnowcurrently
    on Jan 18, 2023
    MemberAuthor

    Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.12only security fixesextension-modulesC modules in the Modules dirtopic-subinterpreterstype-featureA feature request or enhancement

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions