Skip to content

Netlify builds happen for PRs that do not change docs #100072

Closed
Closed
Netlify builds happen for PRs that do not change docs#100072
Assignees
ewdurbinsobolevn
Labels
docsDocumentation in the Doc dirtype-bugAn unexpected behavior, bug, or error

Description

@sobolevn
sobolevn
opened on Dec 7, 2022

Bug report

After #92852 all PRs get a notification from netlify about new doc builds. Example: #100070 (notice no Doc/ changes made)

I don't think it is right:

  1. We are wasting resources for no good reason
  2. It is a noise for both contributors and core devs

But, netlify has build.ignore option that can work similarly to these lines:

cpython/.github/workflows/doc.yml

Lines 23 to 26 in 7031275

paths:
- 'Doc/**'
- 'Misc/**'
- '.github/workflows/doc.yml'

Docs: https://docs.netlify.com/configure-builds/ignore-builds/

I will send a PR to test it :)

Linked PRs

Activity

  1. sobolevn
    added
    type-bugAn unexpected behavior, bug, or error
    docsDocumentation in the Doc dir
    buildThe build process and cross-build
    on Dec 7, 2022
  2. sobolevn
    self-assigned this
    on Dec 7, 2022
  3. sobolevn
    changed the title [-]Netlify build happen for PR that do not change docs[/-] [+]Netlify builds happen for PRs that do not change docs[/+] on Dec 7, 2022
  4. sobolevn
    added a commit that references this issue on Dec 7, 2022

    pythongh-100072: only trigger netlify builds for doc changes

    4bc124c
  5. hugovk
    added a commit that references this issue on Dec 7, 2022

    gh-100072: only trigger netlify builds for doc changes (#100074)

    d92407e

  6. sobolevn commented on Dec 8, 2022

    @sobolevn
    sobolevn
    on Dec 8, 2022
    MemberAuthor

    @hugovk looks like we haven't solved this. Example PR that should not have this message, but still received it: #100114

  7. hugovk commented on Dec 8, 2022

    @hugovk
    hugovk
    on Dec 8, 2022
    Member

    There's two things going on here.

    First, deploys are now being cancelled, as a result of PR #100074. 👍

    We can see that from the comment ("Deploy Preview for python-cpython-preview canceled"), the status checks ("Deploy canceled") and the logs:

    3:05:11 PM: Detected ignore command in Netlify configuration file. Proceeding with the specified command: 'git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF . ../netlify.toml'
3:05:11 PM: User-specified ignore command returned exit code 0. Returning early from build.
3:05:11 PM: Creating deploy upload records
3:05:11 PM: Failed during stage 'checking build content for changes': Canceled build due to no content change

    Second, the deploy notifications need to be turned off. I think this can only be done in the admin settings on Netlify, rather than config, and only one person currently has access, but hopefully we'll get more soon.

  8. sobolevn commented on Dec 8, 2022

    @sobolevn
    sobolevn
    on Dec 8, 2022
    MemberAuthor

    Yes, looks like it: https://docs.netlify.com/site-deploys/notifications/#github-pull-request-comments

  9. CAM-Gerlach commented on Dec 16, 2022

    @CAM-Gerlach
    CAM-Gerlach
    on Dec 16, 2022
    Member

    Just to note, we've gotten an substantial and increasing volume of complaints about these comments from the core developers, as it is causing a large amount of noise and annoyance. While we had a fix ready to go within hours of Neltify being initially enabled, unfortunately as mentioned the blocker here is lack of bus-factor on people with appropriate permissions on the Netlify side. If we could get @Mariatta and @hugovk added there, we can not only solve this problem, but also be able to be responsive to any future issues, while reducing excess load on critical, hardworking infrastructure staff. @ewdurbin ?

    Also, for the record, this is the config we need under the Notifications settings:

    image

  10. ewdurbin commented on Dec 16, 2022

    @ewdurbin
    ewdurbin
    on Dec 16, 2022 via email
    Member

  11. hugovk commented on Dec 16, 2022

    @hugovk
    hugovk
    on Dec 16, 2022
    Member

    Thank you!

    https://www.netlify.com/legal/open-source-policy/ says (emphasis added):

    Netlify loves open source! To show our commitment, we’ve created an Open Source plan to enable projects working on open-source-licensed software to host websites containing information directly related to the community around that software. Our Open Source plan has the same features and limits as our Pro plan, with the addition of free unlimited team members.

  12. ewdurbin commented on Dec 16, 2022

    @ewdurbin
    ewdurbin
    on Dec 16, 2022 via email
    Member
  13. CAM-Gerlach
    assigned
    ewdurbin
    on Dec 16, 2022
  14. CAM-Gerlach
    removed
    buildThe build process and cross-build
    on Dec 16, 2022

  15. CAM-Gerlach commented on Dec 16, 2022

    @CAM-Gerlach
    CAM-Gerlach
    on Dec 16, 2022
    Member

    Thanks @ewdurbin , hopefully they'll respond soon so we don't have to bother you for anything like this in the future! I think we can close this particular issue now, since both parts are now solved.

  16. CAM-Gerlach
    closed this as completedon Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

docsDocumentation in the Doc dirtype-bugAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions