Skip to content

Accept GitHub issues numbered only 32426 or above #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 6 commits into from
Dec 29, 2023
Merged

Accept GitHub issues numbered only 32426 or above #519

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7b2b46d
Accept GitHub issues numbered only 32426 or above
menkotoglou Dec 17, 2023
f864c05
Distinqush if gh-issue is number or < 32426 errors
menkotoglou Dec 18, 2023
724fefb
Fix old test cases to comply with GH issue number range
menkotoglou Dec 18, 2023
9a32376
Add GH issue magic number in a variable
menkotoglou Dec 20, 2023
5980c9a
Update blurb error message
menkotoglou Dec 20, 2023
0fcfb99
Use magic number in exception
menkotoglou Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update blurb error message 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
  • Loading branch information
@menkotoglou @hugovk
menkotoglou and hugovk authored Dec 20, 2023
commit 5980c9ade496de9b3fa8172f49843f3de8d54be6
2 changes: 1 addition & 1 deletion blurb/blurb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ def finish_entry():
# we see in the blurb file, which is a
# better user experience.
if key == "gh-issue" and int(value) < lowest_possible_gh_issue_number:
throw("The gh-issue number should be 32426 or above.")
throw("The gh-issue number must be 32426 or above, not a PR number.")
Comment thread
menkotoglou marked this conversation as resolved.
Outdated

if key in issue_keys:
try:
Expand Down