Repository navigation
Bedevere rejects change that targets another PR #381
Description
In python/cpython#30151, I've written a PR that's based on another PR. In order for the diff to look right but for the code to be based on another PR, I've set the target for the PR as the other PR:
Github supports this workflow and even has some nice features around it. In particular, when python/cpython#30150 is merged, Github will automatically detect the merge and will re-point the 30151 to point to main.
Unfortunately, this workflow trips up on bedevere's check for maintenance branch PR naming, causing the tests not to run:
It would be nice if bedevere would not enforce the naming check if it's not pointing at a maintenance branch. Even better would be for it to recognize that it's pointing at a branch that's pending merge to main or a maintenance branch and use that resolution to make its check.
Impact due to this issue is small, and I'm not even sure there's enough value in fixing the issue, but I'd like to register it regardless.
Activity
jaraco commentedon Dec 16, 2021
For this particular case, I found I was able to actually rebase the dependent change, making it independent, and target it at main separately, working around the issue. This would not have been possible if there had been a hard dependency on the first PR.
arhadthedev commentedon Jun 19, 2022
Is the issue relevant after the migration?
ezio-melotti commentedon Jun 19, 2022
Since the issue seems to be about PRs based on other PRs, the migration doesn't affect this issue. We should verify if the issue is still present or if it got fixed in the meanwhile before closing this.
Add test and fix when base branch isn't a maintenance branch. Fixes #381
gh-381: Add test and fix when base branch isn't a maintenance branch. F…
gh-381: Add test and fix when base branch isn't a maintenance branch. F…
gh-381: Add test and fix when base branch isn't a maintenance branch. F…
gh-381: Add test and fix when base branch isn't a maintenance branch. F…
jaraco commentedon Jul 3, 2022
I wanted to confirm, this change appears to be working, as is evidenced by python/cpython#94528, which targets python/cpython#93965.
Mariatta commentedon Jul 3, 2022
Awesome. Thank you!