Skip to content
This repository was archived by the owner on Nov 23, 2017. It is now read-only.

Ensure get_event_loop returns the running loop when called in a coroutine #355

Closed
vxgmichel wants to merge 18 commits into from
Closed

Ensure get_event_loop returns the running loop when called in a coroutine #355

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b30bcdc
Modify the interface for AbstractEventLoopPolicy
May 25, 2016
705a54c
Update BaseEventLoop.run_forever to set and clear the running loop
May 25, 2016
2e55a60
Ignore event loop policy warnings during the tests
May 25, 2016
f117c75
Fix SleepTests and TimeoutTests
May 25, 2016
1c3a166
Revert "Ignore event loop policy warnings during the tests"
Jun 3, 2016
6e8eaa2
Remove running loop context and event loop policy warnings
Jun 3, 2016
be2c0f1
Revert "Fix SleepTests and TimeoutTests"
Jun 3, 2016
c1cb666
Update docstrings for AbstractEventLoopPolicy
Jun 3, 2016
8788c72
Remove get/set_default_loop
Jun 3, 2016
121cca3
Add disable_get_running_loop method to TestCase
Jun 3, 2016
f1674e8
Update set_event_loop docstring
Jun 3, 2016
c634f79
Merge both try-finally blocks into one in BaseEventLoop.run_forever
Jun 3, 2016
71fcfab
Fix new_event_loop docstring for AbstractEventLoopPolicy
Jun 4, 2016
1a60ee8
Add test_set_running_loop to PolicyTests
Jun 4, 2016
db6774d
Clean set_running_loop
Jun 4, 2016
28c3de3
Add test_get_event_loop_after_set_running_loop to PolicyTests
Jun 4, 2016
5b19055
Fix get_event_loop docstring
Jun 4, 2016
7513577
Update running context in BaseEventLoop.run_forever
Jun 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update docstrings for AbstractEventLoopPolicy
  • Loading branch information
vinmic
vinmic committed Jun 3, 2016
commit c1cb666d4ee5cc5be5cd4690e6e1ed5d5dc7e43a
12 changes: 3 additions & 9 deletions asyncio/events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,7 @@ def get_default_loop(self):
raise NotImplementedError

def set_default_loop(self, loop):
"""Set the default event loop for the current context to loop."""
"""Set the default event loop for the current context."""
raise NotImplementedError

def get_running_loop(self):
Expand Down Expand Up @@ -563,20 +563,14 @@ def set_child_watcher(self, watcher):
# Non-abstract methods

def get_event_loop(self):
"""Return the running event loop if any, and the default event
loop otherwise.
"""
"""Return the running loop if any, and the default loop otherwise."""
running_loop = self.get_running_loop()
if running_loop is not None:
return running_loop
return self.get_default_loop()

def set_event_loop(self, loop):
"""Set the default event loop if the former loop is not currently
running.
"""
if self.get_running_loop() is not None:
raise RuntimeError('The former loop is currently running')
"""Set the default event loop for the current context."""
self.set_default_loop(loop)


Expand Down