Repository navigation
Don't use cElementTree on Python 3 - #8278
Conversation
It's been deprecated and will be removed in 3.9 or 3.10. 3.9.0b1 doesn't have cElementTree. I'd like to bring it back with a deprecation warning to drop in 3.10. See: python/cpython#19921 Signed-off-by: Christian Heimes <christian@python.org>
uranusjr
left a comment
uranusjr
left a comment
There was a problem hiding this comment.
Oh I didn’t realise this is updating a vendor library. This will probably need to be filed upstream.
|
I’ve filed html5lib/html5lib-python#494 upstream. |
Fantastic, thank you. I wasn't sure how pip handles changes to vendored packages. |
We hold patches to vendored packages in If I remember correctly, you'll have to take the "inverse" of the output from the failing CI job: https://travis-ci.org/github/pypa/pip/jobs/689445394 |
It looks like it's git format-patch output (excluding the header and footer) |
|
@pradyunsg tests are passing now, thanks for your assist! |
|
Flaky flaky CI. 😡 |
|
Gah. A single check isn't reporting and it's a check that shouldn't be affecting by this change per-se. I'm gonna go ahead and merge this. Thanks @tiran! ^>^ |
It's been deprecated and will be removed in 3.9 or 3.10. 3.9.0b1 doesn't
have cElementTree. I'd like to bring it back with a deprecation warning
to drop in 3.10.
See: python/cpython#19921
Signed-off-by: Christian Heimes christian@python.org