Skip to content

build PHLTIModel from_interconncetion - #2648

Open
ullmannsven wants to merge 1 commit into
mainfrom
ph_from_interconnection
Open

ullmannsven wants to merge 1 commit into
mainfrom
ph_from_interconnection

Conversation

@ullmannsven

@ullmannsven ullmannsven commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

This PR introduces a new classmethod for PHLTIModel called from_interconnection. The idea is that the method takes a sequence of PHLTIModel (currently S, N and P have to be zero, this can be generalized but I first have to work out the math) and connects them via lossless gyrator interconnection.

Technical description of how the interconnection should be passed

In order to specify which models are connected with each other, a sequence of connections (just a list / tuple) is passed. An entry in connections is a tuple / list of three elements. The first two entries are tuples / lists themself of length two and contain the model index as first entry and as second entry and another tuple / list of lenght 2, specifying the space of the input matrix G of the model (blocks if G has a BlockVectorSpace or idx if not) and which of the blocksubspaces / indices of G should be interconnected. The third entry in top-level tuple / list is the interconnect matrix K.

I would be very happy about feedback to make this connection information passing a bit more easy, this was the first idea I came up with and probably there are better ways to do it.

Future plans

This PR forms the basis for another PR I have planned soon, where I want to introduce a ModularPHReductor, which gets different PHLITModel, reduces each with a specified reductor and then interconnects the reduced models back together. For this interconnection, I require the from_interconnection in this PR (and I think it deserves its own PR that why I did not include the modular reductor changes in here)

TODO

  • add tests
  • maybe rewrite some code in some examples / demos using this method to show how i can be leveraged

@ullmannsven ullmannsven added this to the 2026.2 milestone Oct 4, 2026
@ullmannsven
ullmannsven requested review from pmli and sdrave October 4, 2026 09:29
@ullmannsven ullmannsven self-assigned this Oct 4, 2026
@ullmannsven ullmannsven added the pr:new-feature Introduces a new feature label Oct 4, 2026
@ullmannsven ullmannsven changed the title first draft of PHLTIModel from_interconncetion build PHLTIModel from_interconncetion Oct 4, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:new-feature Introduces a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant