Repository navigation
build PHLTIModel from_interconncetion - #2648
Open
ullmannsven wants to merge 1 commit into
Open
ullmannsven wants to merge 1 commit into
ullmannsven wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new classmethod for
PHLTIModelcalledfrom_interconnection. The idea is that the method takes a sequence of PHLTIModel (currently S, N and P have to be zero, this can be generalized but I first have to work out the math) and connects them via lossless gyrator interconnection.Technical description of how the interconnection should be passed
In order to specify which models are connected with each other, a sequence of
connections(just a list / tuple) is passed. An entry inconnectionsis a tuple / list of three elements. The first two entries are tuples / lists themself of length two and contain the model index as first entry and as second entry and another tuple / list of lenght 2, specifying the space of the input matrix G of the model (blocksifGhas aBlockVectorSpaceoridxif not) and which of the blocksubspaces / indices of G should be interconnected. The third entry in top-level tuple / list is the interconnect matrixK.I would be very happy about feedback to make this connection information passing a bit more easy, this was the first idea I came up with and probably there are better ways to do it.
Future plans
This PR forms the basis for another PR I have planned soon, where I want to introduce a
ModularPHReductor, which gets differentPHLITModel, reduces each with a specified reductor and then interconnects the reduced models back together. For this interconnection, I require thefrom_interconnectionin this PR (and I think it deserves its own PR that why I did not include the modular reductor changes in here)TODO