Conversation
The operators were matched anywhere, so identifiers such as `isfile` were split into `is` and `file`. Only word-like operators need boundaries; symbol operators like `=>` and `..` must keep matching regardless of surrounding whitespace. Fixes pygments#3308.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3308.
Summary
The Hare lexer listed the operators
asandisalongside thesymbol operators
=>,..and...in a singlewords()rule without word boundaries. Because
asandisconsist ofword characters, the rule matched them as a prefix of any identifier
starting with those letters, e.g.
isfilewas split into anOperatorisfollowed byNamefile.This change adds word boundaries to the word-like operators only, and
keeps the symbol operators (
=>,..,...) matchingunconditionally, as those must also match next to word characters
(e.g.
i < len && arr[i]..style syntax).Changes
pygments/lexers/hare.py: split the operator rule soas/isuseprefix/suffixword boundaries while=>,..,...stayunbounded.
tests/snippets/hare/test_keyword_operators.txt: regression snippetcovering identifiers such as
isfile,ascii,is_validand thestandalone
as/isoperators.CHANGES: changelog entry under 2.22.0.Tests
Verified locally with the full test suite:
pytest tests/→ 5331 passed, 16 skippedwith it.