Skip to content

Add randomSampleOne #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JordanMartinez merged 6 commits into from
Nov 3, 2020
Merged

Add randomSampleOne #114

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4fcd0b2
Add generate
JordanMartinez Nov 1, 2020
95e6132
Change generate size to 10
JordanMartinez Nov 2, 2020
53b6934
Rename generate to randomOne
JordanMartinez Nov 2, 2020
9db0d1e
Refer people to randomOne if they try randomSample
JordanMartinez Nov 2, 2020
78d22bf
Rename randomOne to randomSampleOne
JordanMartinez Nov 3, 2020
5038acf
Fix comment
JordanMartinez Nov 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refer people to randomOne if they try randomSample
  • Loading branch information
@JordanMartinez
JordanMartinez committed Nov 2, 2020
commit 9db0d1e3b7d7455b188fd877af93bed2f7740d6f
2 changes: 1 addition & 1 deletion src/Test/QuickCheck/Gen.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ randomSample' n g = do
seed <- randomSeed
pure $ sample seed n g

-- | Get a random sample of 10 values
-- | Get a random sample of 10 values. For a single value, use `randomOne`.

@hdgarrood hdgarrood Nov 3, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment needs updating now

@JordanMartinez JordanMartinez Nov 3, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

randomSample :: forall a. Gen a -> Effect (Array a)
randomSample = randomSample' 10

Expand Down