Skip to content

Final improvements to 1D plotting wrappers #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukelbd merged 11 commits into from
Jul 11, 2021
Merged

Final improvements to 1D plotting wrappers #258

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4445ab2
Nicer default font sizes
lukelbd Jul 8, 2021
00d5a86
Fix outdated links and cleanup api docs
lukelbd Jul 9, 2021
a0d4adb
More sensible order for 1D plot examples and API docs
lukelbd Jul 9, 2021
87fa3a1
Always surround docstrings with newlines
lukelbd Jul 9, 2021
3ec681e
Nitpicky style consistency
lukelbd Jul 9, 2021
3b1cbaf
Major 1d wrapper refactor, add (plot|scatter)x, add 'data' key
lukelbd Jul 9, 2021
23d4cc9
Fix issues with show_(cmaps|cycles) due to padding fix (#221)
lukelbd Jul 9, 2021
bbcffa8
Fix recently introduced bug where fail to convert twilight_shifted
lukelbd Jul 9, 2021
d083438
Fix issue where we overwrite mcm.get_cmap with useless docstring
lukelbd Jul 9, 2021
2ebb682
Fix minor bugs after refactor
lukelbd Jul 9, 2021
e18a46a
Final bugfixes after 1dplots refactor
lukelbd Jul 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Nitpicky style consistency
  • Loading branch information
@lukelbd
lukelbd committed Jul 9, 2021
commit 3ec681e7a6767cf3b4fb47c583370852dba08948
7 changes: 1 addition & 6 deletions proplot/internals/warnings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,12 @@ def getter(self):
f'{type(self).__name__}.{property} instead.'
)
return getattr(self, '_' + property)

def setter(self, value):
def setter(self, value): # noqa: E306
_warn_proplot(
f'set_{property}() was deprecated in {version}. The property is '
f'now read-only.'
)
return

getter.__name__ = f'get_{property}'
setter.__name__ = f'set_{property}'

Expand All @@ -61,18 +59,15 @@ def _rename_objs(version, **kwargs):
"""
wrappers = []
for old_name, func_or_class in kwargs.items():

def wrapper(*args, old_name=old_name, func_or_class=func_or_class, **kwargs):
new_name = func_or_class.__name__
_warn_proplot(
f'{old_name!r} was deprecated in version {version} and will be '
f'removed in the next major release. Please use {new_name!r} instead.'
)
return func_or_class(*args, **kwargs)

wrapper.__name__ = old_name
wrappers.append(wrapper)

if len(wrappers) == 1:
return wrappers[0]
else:
Expand Down