Prevent shared-label algorithm from ignoring/overwriting distinct axis labels #384

Activity

1. syrte commented on Aug 29, 2022

   

   syrte

   on Aug 29, 2022

   More actions

   Try set p.subplots(..., sharey=False, ...)?
2. pulkin commented on Aug 29, 2022

   

   pulkin

   on Aug 29, 2022

   Author

   More actions

   Try set p.subplots(..., sharey=False, ...)?

   Labels re-appear in multitudes (i.e. expected behavior).
3. pulkin commented on Sep 3, 2022

   

   pulkin

   on Sep 3, 2022

   Author

   More actions

   The problem is this code:
   

   proplot/proplot/figure.py

   Lines 1185 to 1206 in 29bc955

   	for ax in self._subplot_dict.values():
   	if isinstance(ax, paxes.CartesianAxes):
   	ax._apply_axis_sharing() # always!
   	else:
   	continue
   	pos = getattr(ax, x + 'axis').get_label_position()
   	if ax in seen or pos not in ('bottom', 'left'):
   	continue # already aligned or cannot align
   	axs = ax._get_span_axes(pos, panels=False) # returns panel or main axes
   	if any(getattr(ax, '_share' + x) for ax in axs):
   	continue # nothing to align or axes have parents
   	seen.update(axs)
   	if span or align:
   	if hasattr(self, '_align_label_groups'):
   	group = self._align_label_groups[x]
   	else:
   	group = getattr(self, '_align_' + x + 'label_grp', None)
   	if group is not None: # fail silently to avoid fragile API changes
   	for ax in axs[1:]:
   	group.join(axs[0], ax) # add to grouper
   	if span:
   	self._update_axis_label(pos, axs)

   
   ax._get_span_axes(pos, panels=False) returns every axes adjacent to the left edge: 1, 2, 3, 4, 5, 8 to share the same y axis label. I patched it like this:

   ...
               axs = ax._get_span_axes(pos, panels=False)  # returns panel or main axes
               if any(getattr(ax, '_share' + x) for ax in axs):
                   continue  # nothing to align or axes have parents
               _ref_label_text = getattr(ax, x + 'axis').label.get_text()  # PATCH
               axs = list(_ax for _ax in axs if getattr(_ax, x + 'axis').label.get_text() == _ref_label_text)  # PATCH
               seen.update(axs)
   ...

   And the desired effect is kinda achieved.
4. pulkin

   added a commit that references this issue on Sep 3, 2022

   close proplot-dev#384 (sort of)

   This issue will close once commit acb1cec is merged into the 'master' branch.

   acb1cec
5. pulkin commented on Sep 7, 2022

   

   pulkin

   on Sep 7, 2022

   Author

   More actions

   There might be another issue on top of this: super-label coordinates are computed incorrectly in ._get_align_coord. The computation is based on some intermediate alignment of axes which is changed afterwards. If I do this

   for i in ax:
       pos = i.get_subplotspec().get_position(fig)
       print(f"{i=} {pos=}")

   before and after figure is printed I get different results.
6. lukelbd commented on Mar 29, 2023

   

   lukelbd

   on Mar 29, 2023

   Collaborator

   More actions

   Thanks for the report and PR #385 -- will take a closer look when I can. Agree this makes sense -- the shared label algorithm should only consider subplots with identical labels. The sharing algorithm is pretty klunky right now.
7. lukelbd

   added

   enhancement

   on Mar 29, 2023
8. lukelbd

   changed the title [-]Missing label[/-] [+]Prevent shared-label algorithm from ignoring/overwriting distinct axis labels[/+] on Mar 29, 2023