Improve error message for non-numeric strands construction (#9218) - #9229
Open
LalitNarayanYadav wants to merge 2 commits into
Open
LalitNarayanYadav wants to merge 2 commits into
LalitNarayanYadav wants to merge 2 commits into
Conversation
LalitNarayanYadav
marked this pull request as ready for review
September 30, 2026 18:09
Continuous ReleaseCDN linkPublished PackagesCommit hash: b9e56b1 Previous deploymentsThis is an automated message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #9218
Changes
Improves the error thrown in
mapPrimitiveDepsToIDs(src/strands/ir_builders.js) when a non-numeric value is passed into a scalar or vector construction.Previously, the error stringified the raw value. In the case from #9218 (using
filterColordirectly instead offilterColor.texCoord), this dumped the internal hook callback's source code into the message.Now the error:
Before / after
Before (from #9218):
After:
Scope
This covers only the "better error content at the throw site" part of #9218. The following are left as follow-up work:
strandsNodeframes out of the stack traceTests
Adds a regression test in
test/unit/webgl/p5.Shader.jsthat reproduces thefilterColor * 30mistake from the issue and asserts on the new message. The fullp5.Shadersuite passes (161/161).PR Checklist
npm run lintpasses