Search pgsql-bugs too when attaching a thread - #121
Open
Shihao-Zhong wants to merge 1 commit into
Open
Shihao-Zhong wants to merge 1 commit into
Shihao-Zhong wants to merge 1 commit into
Conversation
The "Attach thread" search only looked at pgsql-hackers, so a patch for a bug report could only be attached by pasting a message id. Search every list in ARCHIVES_SEARCH_LISTS, which is pgsql-hackers and pgsql-bugs by default, and merge the results. Fixes postgres#117
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #117.
The "Attach thread" search only looked at pgsql-hackers. A patch for a bug report could only be attached by pasting a message id, which is easy to miss.
getThreadsnow searches every list in a new setting,ARCHIVES_SEARCH_LISTS, which defaults to pgsql-hackers and pgsql-bugs. Results are merged newest first, a message sent to both lists shows up once, and the total is still capped at 100.This costs one more request to the archives server per search. I could not test against the real archives API, since it is restricted by host. The
latest.jsonendpoint in pgarchives takes any list name, so I expect it to work as is.The dialog does not show which list a message came from. I can add that if you want it.
🤖 Generated with Claude Code