feat(useVideoTexture): now accepting a src that is a MediaStream - #1370
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0d08fd5:
|
abernier
commented
Mar 30, 2023
abernier
commented
Mar 30, 2023
abernier
force-pushed
the
abernier/usevideotexture-mediastream
branch
from
March 30, 2023 11:23
ea56ffe to
d750c5b
Compare
abernier
changed the title
abernier
force-pushed
the
abernier/usevideotexture-mediastream
branch
from
March 30, 2023 17:12
d750c5b to
615849d
Compare
abernier
force-pushed
the
abernier/usevideotexture-mediastream
branch
from
March 30, 2023 18:02
615849d to
1db9850
Compare
abernier
force-pushed
the
abernier/usevideotexture-mediastream
branch
from
March 30, 2023 18:12
1db9850 to
0d08fd5
Compare
drcmda
marked this pull request as ready for review
March 30, 2023 18:21
drcmda
approved these changes
Mar 30, 2023
|
🎉 This PR is included in version 9.60.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why / What
Trying to configure
useVideoTextureto also accept a mediaStream (from.getDisplayMedia()) to allow screen sharing into it.See: https://discord.com/channels/740090768164651008/1090246938949079062/1090665612721791097
suzi-on-dplus2.mov
Checklist