Skip to content

Typing 1 b #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bouwew wants to merge 29 commits into
base: main
Choose a base branch
from
Draft

Typing 1 b #870

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
eca817e
Initial typed xml reading attempt (incomplete)
CoMPaTech Dec 28, 2025
408682b
Further progress
CoMPaTech Dec 29, 2025
6c6b3f2
Further progress - appliance typos
CoMPaTech Dec 29, 2025
709e84c
Some progress
CoMPaTech Dec 29, 2025
660acd8
More progress
CoMPaTech Dec 29, 2025
826c387
Further cleaning
CoMPaTech Dec 29, 2025
baf3419
Gateway progress
CoMPaTech Dec 31, 2025
9cd1b54
Fix after rebase
bouwew Jan 24, 2026
91b6877
Contents -> content
bouwew Jan 24, 2026
e2ad185
Fix module_data
bouwew Jan 24, 2026
9c011df
Fix another contents
bouwew Jan 24, 2026
6d09ec6
Add xmltodict to requirements
bouwew Apr 5, 2026
04698e7
Change index from 5 to 4
bouwew Apr 5, 2026
7e393f5
Update _appl_heater_central_info()
bouwew Apr 6, 2026
1d36e07
Update check_heater_central()
bouwew Apr 7, 2026
7c84129
And use
bouwew Apr 7, 2026
39ab2b3
Fixes
bouwew Apr 7, 2026
d7fa9f7
More _appl_heater_central_info() updating
bouwew Apr 13, 2026
85bfdda
Fix contents
bouwew Apr 13, 2026
613cbb3
Update _appl_thermostat_info()
bouwew Apr 13, 2026
aeee690
Update _get_appliances_with_offset_functionality()
bouwew Apr 13, 2026
8e3c64c
get_groups()
bouwew Apr 13, 2026
a4a8822
Disable prints, add logger
bouwew Apr 17, 2026
6728175
Disable initial Adam testcase
bouwew Apr 17, 2026
bbe0e9d
Add _create_gw_entities() call
bouwew Apr 17, 2026
a998ae0
Extend Appliance class
bouwew Apr 18, 2026
51f9db4
Correct to appl.id
bouwew Apr 18, 2026
17e6798
Various improvements
bouwew Apr 18, 2026
e9d0d42
fixup: typing_1_b Python code fixed using ruff
Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update _appl_heater_central_info()
  • Loading branch information
@bouwew
bouwew committed Apr 6, 2026
commit 7e393f5c7a16e825e0acde4bee55374e1af8185b
10 changes: 5 additions & 5 deletions plugwise/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
GwEntityData,
# ModuleData,
)
from plugwise.model import Appliance, DomainObjects
from plugwise.util import check_heater_central, check_model, return_valid
Comment on lines +21 to +22

@coderabbitai coderabbitai Bot Apr 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Pipeline: unused imports DomainObjects and return_valid (Ruff F401).

Both block CI.

-from plugwise.model import Appliance, DomainObjects
-from plugwise.util import check_heater_central, check_model, return_valid
+from plugwise.model import Appliance
+from plugwise.util import check_heater_central, check_model
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
from plugwise.model import Appliance, DomainObjects
from plugwise.util import check_heater_central, check_model, return_valid
from plugwise.model import Appliance
from plugwise.util import check_heater_central, check_model
🧰 Tools
🪛 GitHub Actions: Latest commit

[error] 21-21: Ruff F401: plugwise.model.DomainObjects imported but unused.

[error] 22-22: Ruff F401: plugwise.util.return_valid imported but unused.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@plugwise/common.py` around lines 21 - 22, The import line imports unused
symbols DomainObjects and return_valid causing a linter failure; remove these
unused imports from the from plugwise.model / from plugwise.util import
statement (keep Appliance, check_heater_central, check_model) so the import
becomes only the used names, or if they are intended to be used add the missing
usage. Specifically edit the import that currently references DomainObjects and
return_valid to eliminate those two symbols.


from defusedxml import ElementTree as etree
Expand Down Expand Up @@ -80,8 +81,7 @@ def check_name(self, name: str) -> bool:

def _appl_heater_central_info(
self,
appl: Munch,
xml_1: etree.Element,
appl: Appliance,
legacy: bool,
xml_2: etree.Element = None,
xml_3: etree.Element = None,
Expand Down Expand Up @@ -117,9 +117,9 @@ def _appl_heater_central_info(
return (
Munch()
) # no module-data present means the device has been removed
appl.vendor_name = module_data["vendor_name"]
appl.hardware = module_data["hardware_version"]
appl.model_id = module_data["vendor_model"] if not legacy else None
appl.vendor_name = module_data.vendor_name
appl.hardware = module_data.hardware_version
appl.model_id = module_data.vendor_model if not legacy else None
appl.model = (
"Generic heater/cooler" if self._cooling_present else "Generic heater"
)
Expand Down