Skip to content

Share chart button #7802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marthacryan merged 26 commits into from
Jun 17, 2026
Merged

Share chart button #7802

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
42c9601
add button placeholder which shows chart JSON
emilykl Apr 14, 2026
8ce5512
add icon
emilykl May 11, 2026
ad9ddfc
use existing sendChartToCloud function
emilykl May 14, 2026
100da7b
update plot-schema
emilykl May 14, 2026
82f5437
Update approach to use postMessage and wait for ready signal before s…
marthacryan May 28, 2026
fddd50e
Merge branch 'master' of github.com:plotly/plotly.js into upload-to-c…
marthacryan May 28, 2026
ba91b11
Create a confirmation dialog
marthacryan May 28, 2026
717fc26
Add default URL for plotlyServerURL
marthacryan May 28, 2026
8774b9c
Update string to indicate success
marthacryan Jun 9, 2026
13b8f12
Update src/plot_api/plot_config.js
marthacryan Jun 11, 2026
a44f6ef
Add localization
marthacryan Jun 11, 2026
836d24c
Address review
marthacryan Jun 11, 2026
1f47ebd
Update default cloud URL
marthacryan Jun 11, 2026
83deac2
Update src/components/modebar/cloud_confirm.js
marthacryan Jun 11, 2026
852dc1f
Set default to false for showSendToCloud
marthacryan Jun 11, 2026
4a71e43
Merge changes
marthacryan Jun 11, 2026
ff34976
Update plot-schema in dist
marthacryan Jun 11, 2026
e5933bd
Revert "Update plot-schema in dist"
emilykl Jun 15, 2026
c1b7122
update test/plot-schema.json
emilykl Jun 15, 2026
c28c434
Update default URL for upload to empty string until plotly cloud endp…
marthacryan Jun 16, 2026
da868be
Merge branch 'upload-to-cloud-proto' of github.com:plotly/plotly.js i…
marthacryan Jun 16, 2026
bf8971a
Update src/components/modebar/cloud_confirm.js
marthacryan Jun 16, 2026
ada548c
Update src/components/modebar/buttons.js
marthacryan Jun 16, 2026
0ee9501
Move validation logic to prevent dialog opening for invalid URLs
marthacryan Jun 16, 2026
299d9a5
Merge branch 'upload-to-cloud-proto' of github.com:plotly/plotly.js i…
marthacryan Jun 16, 2026
5a7a7af
Update default for test plot schema
marthacryan Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/plot_api/plot_config.js 
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
  • Loading branch information
@marthacryan @emilykl
marthacryan and emilykl authored Jun 11, 2026
commit 13b8f12e1ebbcfd56c4d4b881d1c3a1e4e97cb5a
4 changes: 2 additions & 2 deletions src/plot_api/plot_config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,8 @@ var configAttributes = {
description: [
'Should we include a modebar button that sends this chart to a URL',
'specified by `plotlyServerURL`, for sharing the chart with others?',
'Note that this button can (depending on `plotlyServerURL` being set)',
'send your data to an external server.'
'Note that this button will (after a confirmation step)',
'send chart data to an external server.'
].join(' ')
},
modeBarButtonsToRemove: {
Expand Down
Loading