Skip to content

fix(axes): format tick labels correctly for small numbers in exponential notation #7768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camdecoster merged 6 commits into from
Jul 13, 2026
Merged

fix(axes): format tick labels correctly for small numbers in exponential notation #7768

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ca08f3a
fix(axes): format tick labels correctly for small numbers in exponent…
Hasnaathussain Apr 22, 2026
8908ff9
Apply maintainer suggestion: use toFixed instead of string manipulation
Hasnaathussain Jun 21, 2026
bc032db
Subtract rounding increment when using `toFixed`
camdecoster Jun 23, 2026
40334d5
Refactor rounding logic; don't apply rounding increment to value
camdecoster Jun 24, 2026
8a3a1cc
test: add tests for tick formatting of small numbers in exponential n…
Hasnaathussain Jun 27, 2026
278319f
Update draftlog
camdecoster Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply maintainer suggestion: use toFixed instead of string manipulation
  • Loading branch information
@Hasnaathussain
Hasnaathussain committed Jun 21, 2026
commit 8908ff993d27ce385a70161ab963c796dc9ad270
22 changes: 1 addition & 21 deletions src/plots/cartesian/axes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2210,27 +2210,7 @@ function numFormat(v, ax, fmtoverride, hover) {
v = v.slice(0, Math.max(0, v.length + tickRound));
for(var i = tickRound; i < 0; i++) v += '0';
} else {
var vStr = String(v);
var ep = vStr.indexOf('e');
if(ep >= 0) {
var mantissa = vStr.slice(0, ep);
var exponentStr = vStr.slice(ep);
var dp = mantissa.indexOf('.') + 1;
var exponentVal = parseInt(exponentStr.slice(1), 10);
var adjustedTickRound = tickRound + exponentVal;
if(dp) {
if(adjustedTickRound < 0) {
mantissa = mantissa.slice(0, dp - 1);
} else {
mantissa = mantissa.slice(0, dp + adjustedTickRound).replace(/\.?0+$/, '');
}
}
v = mantissa + exponentStr;
} else {
v = vStr;
var dp = v.indexOf('.') + 1;
if(dp) v = v.slice(0, dp + tickRound).replace(/\.?0+$/, '');
}
v = v.toFixed(Math.max(0, Math.min(20, tickRound))).replace(/\.?0+$/, '');
}
// insert appropriate decimal point and thousands separator
v = Lib.numSeparate(v, ax._separators, separatethousands);
Expand Down
Loading