You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes#14260 by resurfacing original error on rollback failure.
No tests added as this is not testable with H2 (see note in issue).
Also, I am not sure that the "restore isolation level" step makes much sense, as the connection is closed immediately after (by withConnection -> finally). I kept it and safeguarded it like the rollback, let me know what you think.
CI seems to be failing because of a configuration issue ? Does not seem related to this PR
sbt connection file /home/runner/work/playframework/playframework/project/target/active.json is corrupt or unreadable: sjsonnew.shaded.org.typelevel.jawn.IncompleteParseException: exhausted input; starting a new server
[info] sbt server is booting up
[error] failed to connect to server
Can you clarify what kind of tests you mean? As I explained, the current testing framework with in-memory H2 can not cover the cases here. We could integrate the scenarios provided in the reproduction repo linked in issue, but that would mean adding TestContainers dependencies, it is not such a light decision.
Can you clarify what kind of tests you mean? As I explained, the current testing framework with in-memory H2 can not cover the cases here. We could integrate the scenarios provided in the reproduction repo linked in issue, but that would mean adding TestContainers dependencies, it is not such a light decision.
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14260 by resurfacing original error on rollback failure.
No tests added as this is not testable with H2 (see note in issue).
Also, I am not sure that the "restore isolation level" step makes much sense, as the connection is closed immediately after (by
withConnection->finally). I kept it and safeguarded it like the rollback, let me know what you think.