Conversation
tsawada
force-pushed
the
tsawada/gzipfilter-etag
branch
from
March 21, 2026 05:59
4bb9d3f to
497be8f
Compare
Member
|
@Mergifyio rebase |
mkurz
force-pushed
the
tsawada/gzipfilter-etag
branch
from
April 29, 2026 08:06
20b9108 to
7fe7d9e
Compare
Contributor
|
Deprecation notice: This pull request comes from a fork and was rebased using |
Contributor
✅ Branch has been successfully rebased |
mkurz
force-pushed
the
tsawada/gzipfilter-etag
branch
from
June 19, 2026 11:49
7fe7d9e to
669d5ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Purpose
This PR updates GzipFilter to weaken strong ETags when compressing a Result.
If the Result contains an unquoted ETag, which is malformed according to RFC 9110, Section 8.8.3, GzipFilter removes the ETag header entirely.
I think this behavior is the safest fallback to prevent any downstream caching issue with invalid headers. It seems Cloudflare handles malformed ETags this way, according to their documentation.
https://developers.cloudflare.com/cache/reference/etag-headers/#important-remarks
I believe this improves adherence to the HTTP standards.