Skip to content

Timezone find and fix and sonar codemod #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clavedeluna merged 5 commits into from
Aug 30, 2024
Merged

Timezone find and fix and sonar codemod #802

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f6c0ccb
add core codemod
clavedeluna Aug 19, 2024
1a86c75
document
clavedeluna Aug 19, 2024
ccc7f75
add sonar codemod
clavedeluna Aug 19, 2024
88cf784
update pygoat findings
clavedeluna Aug 19, 2024
e6da90f
Hardening suggestions for codemodder-python / sonar-timezone (#818)
pixeebot[bot] Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Hardening suggestions for codemodder-python / sonar-timezone (#818) 
* update pygoat findings

* Use Assignment Expression (Walrus) In Conditional

---------

Co-authored-by: clavedeluna <danalitovsky+git@gmail.com>
Co-authored-by: pixeebot[bot] <104101892+pixeebot[bot]@users.noreply.github.com>
  • Loading branch information
@pixeebot @clavedeluna
pixeebot[bot] and clavedeluna authored Aug 30, 2024
commit e6da90f7623d7cf572e2e0c8c9701f4c30c87968
3 changes: 1 addition & 2 deletions src/core_codemods/timezone_aware_datetime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,8 @@ def leave_Call(self, original_node: cst.Call, updated_node: cst.Call):
return updated_node

def _determine_module_and_kwarg(self, original_node: cst.Call):
maybe_name = self.get_aliased_prefix_name(original_node, self._module_name)

if maybe_name:
if maybe_name := self.get_aliased_prefix_name(original_node, self._module_name):
# it's a regular import OR alias import
if maybe_name == self._module_name:
module = "datetime.datetime"
Expand Down